From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] ARM: Fix overflow in MMU setup
Date: Sat, 30 Aug 2014 11:14:26 -0400 [thread overview]
Message-ID: <20140830151426.GI19374@bill-the-cat> (raw)
In-Reply-To: <1407109546-5367-1-git-send-email-marex@denx.de>
On Mon, Aug 04, 2014 at 01:45:46AM +0200, Marek Vasut wrote:
> The patch fixes a corner case where adding size to DRAM start resulted
> in a value (1 << 32), which in turn overflew the u32 computation, which
> resulted in 0 and it therefore prevented correct setup of the MMU tables.
>
> The addition of DRAM bank start and it's size can end up right at the end
> of the address space in the special case of a machine with enough memory.
> To prevent this overflow, shift the start and size separately and add them
> only after they were shifted.
>
> Hopefully, we only have systems in tree which have DRAM size aligned to
> 1MiB boundary. If not, this patch would break such systems. On the other
> hand, such system would be broken by design anyway.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140830/a1488a2c/attachment.pgp>
prev parent reply other threads:[~2014-08-30 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-03 23:45 [U-Boot] [PATCH] ARM: Fix overflow in MMU setup Marek Vasut
2014-08-30 15:14 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140830151426.GI19374@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox