From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] imx: ddr: Move mx6q_4x_mt41j128.cfg to mx6sabresd board dir
Date: Mon, 01 Sep 2014 21:02:38 +0200 [thread overview]
Message-ID: <20140901190238.5CB1138237E@gemini.denx.de> (raw)
In-Reply-To: <CAP9ODKonaZ9v76WAdd4k7or_kUWF=ATTLf+-DrqgQYVgKbt8Bg@mail.gmail.com>
Dear Otavio,
In message <CAP9ODKonaZ9v76WAdd4k7or_kUWF=ATTLf+-DrqgQYVgKbt8Bg@mail.gmail.com> you wrote:
>
> > But in the next sentence you state that this very file is also used by
> > another board (cgtqmx6qeval) - so apparently it is NOT a board
> > specific file. Actually this makes even more sense to me, as I would
> > expect that the file is more specific to the DDR type than to the
> > board.
> >
> > So why exactly do you think it would be better to move this into a
> > board specific place?
>
> All the calibration has been done by Freescale and for the SABRE SD
> board. This is not guarantee it works in other boards, neither
> expected. Congatec opted to include this file but it is their choice
> and moving to the board file makes it more evident.
This may be all true, but nevertheless this is NOT board specific
code. And you can already see it being reused by other boards, so the
most natural way to handle it is to factor it out into a common
directory. And actually this is what we had before.
If we are going to change code, we should have a good reason for such
a change, like fixing bugs, adding features, or cleaning up. What
exactly is that good reason here? Moving code used by more than one
board from a common place to a board-specific one make things worse,
not better.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Until you walk a mile in another man's moccasins, you can't imagine
the smell.
next prev parent reply other threads:[~2014-09-01 19:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 14:20 [U-Boot] [PATCH v2] imx: ddr: Move mx6q_4x_mt41j128.cfg to mx6sabresd board dir Nitin Garg
2014-09-01 14:24 ` Fabio Estevam
2014-09-01 14:33 ` Otavio Salvador
2014-09-01 17:59 ` Wolfgang Denk
2014-09-01 18:10 ` Otavio Salvador
2014-09-01 19:02 ` Wolfgang Denk [this message]
2014-09-01 19:05 ` Michael Trimarchi
2014-09-01 19:11 ` Otavio Salvador
2014-09-01 19:20 ` Wolfgang Denk
2014-09-01 19:24 ` Wolfgang Denk
2014-09-01 22:27 ` Fabio Estevam
2014-09-01 23:34 ` Eric Nelson
2014-09-01 23:51 ` Fabio Estevam
2014-09-12 7:53 ` Stefano Babic
2014-09-13 21:07 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901190238.5CB1138237E@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox