From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] imx: ddr: Move mx6q_4x_mt41j128.cfg to mx6sabresd board dir
Date: Mon, 01 Sep 2014 21:24:34 +0200 [thread overview]
Message-ID: <20140901192434.95BD3382237@gemini.denx.de> (raw)
In-Reply-To: <1409581243-12695-1-git-send-email-nitin.garg@freescale.com>
Dear Nitin Garg,
In message <1409581243-12695-1-git-send-email-nitin.garg@freescale.com> you wrote:
> Move board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg to
> board/freescale/mx6sabresd/mx6q_4x_mt41j128.cfg as this is
> was designed for the mx6sabresd board. This also updates the
> cgtqmx6qeval which makes use of this configuration.
I've made my mind up. I hereby NAK this patch, as it would basically
revert Fabio Estevam's commit af7ec0b which moved the originally
board-specific code to a common place:
commit af7ec0b0582f658873713c311497626c571f3b31
Author: Fabio Estevam <fabio.estevam@freescale.com>
Date: Thu Sep 13 03:18:19 2012 +0000
mx6q: Factor out common DDR3 init code
Factor out common DDR3 initialization code, allowing easier
maintainance of such scripts.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Fabio's intention was a good one, as is proven by the re-use of this
code by other boards.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Once they go up, who cares where they come down? That's not my
department." - Werner von Braun
next prev parent reply other threads:[~2014-09-01 19:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 14:20 [U-Boot] [PATCH v2] imx: ddr: Move mx6q_4x_mt41j128.cfg to mx6sabresd board dir Nitin Garg
2014-09-01 14:24 ` Fabio Estevam
2014-09-01 14:33 ` Otavio Salvador
2014-09-01 17:59 ` Wolfgang Denk
2014-09-01 18:10 ` Otavio Salvador
2014-09-01 19:02 ` Wolfgang Denk
2014-09-01 19:05 ` Michael Trimarchi
2014-09-01 19:11 ` Otavio Salvador
2014-09-01 19:20 ` Wolfgang Denk
2014-09-01 19:24 ` Wolfgang Denk [this message]
2014-09-01 22:27 ` Fabio Estevam
2014-09-01 23:34 ` Eric Nelson
2014-09-01 23:51 ` Fabio Estevam
2014-09-12 7:53 ` Stefano Babic
2014-09-13 21:07 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901192434.95BD3382237@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox