[U-Boot] [PATCH v2] imx: ddr: Move mx6q_4x_mt41j128.cfg to mx6sabresd board dir

Otavio Salvador
2014-09-01T19:11:18Z

Wolfgang,

On Mon, Sep 1, 2014 at 4:02 PM, Wolfgang Denk <wd@denx.de> wrote:
> In message <CAP9ODKonaZ9v76WAdd4k7or_kUWF=ATTLf+-DrqgQYVgKbt8Bg@mail.gmail.com> you wrote:
>>
>> > But in the next sentence you state that this very file is also used by
>> > another board (cgtqmx6qeval) - so apparently it is NOT a board
>> > specific file. Actually this makes even more sense to me, as I would
>> > expect that the file is more specific to the DDR type than to the
>> > board.
>> >
>> > So why exactly do you think it would be better to move this into a
>> > board specific place?
>>
>> All the calibration has been done by Freescale and for the SABRE SD
>> board. This is not guarantee it works in other boards, neither
>> expected. Congatec opted to include this file but it is their choice
>> and moving to the board file makes it more evident.
>
> This may be all true, but nevertheless this is NOT board specific
> code. And you can already see it being reused by other boards, so the
> most natural way to handle it is to factor it out into a common
> directory. And actually this is what we had before.
>
> If we are going to change code, we should have a good reason for such
> a change, like fixing bugs, adding features, or cleaning up. What
> exactly is that good reason here? Moving code used by more than one
> board from a common place to a board-specific one make things worse,
> not better.

I disagree (but this is my personal view on this). The reason why I
disagree is because the DDR calibration is very design dependant so
if/when Freescale optimize their DDR data setting they may break any
other board using it however they shouldn't be blamed by it as this is
their DDR settings. Any board including this file (which can be and is
done) takes the responsibility and risks.

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750