[U-Boot] [PATCH v2] imx: ddr: Move mx6q_4x_mt41j128.cfg to mx6sabresd board dir

Wolfgang Denk
2014-09-01T19:24:34Z

Dear Nitin Garg,

In message <1409581243-12695-1-git-send-email-nitin.garg@freescale.com> you wrote:
> Move board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg to
> board/freescale/mx6sabresd/mx6q_4x_mt41j128.cfg as this is
> was designed for the mx6sabresd board. This also updates the
> cgtqmx6qeval which makes use of this configuration.

I've made my mind up. I hereby NAK this patch, as it would basically
revert Fabio Estevam's commit af7ec0b which moved the originally
board-specific code to a common place:

commit af7ec0b0582f658873713c311497626c571f3b31
Author: Fabio Estevam <fabio.estevam@freescale.com>
Date: Thu Sep 13 03:18:19 2012 +0000

mx6q: Factor out common DDR3 init code

Factor out common DDR3 initialization code, allowing easier
maintainance of such scripts.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Fabio's intention was a good one, as is proven by the re-use of this
code by other boards.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Once they go up, who cares where they come down? That's not my
department." - Werner von Braun