[U-Boot] [PATCH v2] imx: ddr: Move mx6q_4x_mt41j128.cfg to mx6sabresd board dir

Otavio Salvador
2014-09-01T18:10:40Z

Wolfgang,

(Dropping Leo e-mail as it bounces, adding Alex who seem to be working
on BSP support at Congatec now)

On Mon, Sep 1, 2014 at 2:59 PM, Wolfgang Denk <wd@denx.de> wrote:
> In message <1409581243-12695-1-git-send-email-nitin.garg@freescale.com> you wrote:
>> Move board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg to
>> board/freescale/mx6sabresd/mx6q_4x_mt41j128.cfg as this is
>> was designed for the mx6sabresd board. This also updates the
>> cgtqmx6qeval which makes use of this configuration.
>
> Sorry, but I don't get it. First you say, that mx6q_4x_mt41j128.cfg
> is a mx6sabresd specific file, and move it to the board specific
> directory.
>
> But in the next sentence you state that this very file is also used by
> another board (cgtqmx6qeval) - so apparently it is NOT a board
> specific file. Actually this makes even more sense to me, as I would
> expect that the file is more specific to the DDR type than to the
> board.
>
> So why exactly do you think it would be better to move this into a
> board specific place?

All the calibration has been done by Freescale and for the SABRE SD
board. This is not guarantee it works in other boards, neither
expected. Congatec opted to include this file but it is their choice
and moving to the board file makes it more evident.

Some vendors choose to reuse other vendors provided memory
configuration (this has been done in some board using Nitrogen6X
values for example). If this is good or bad ... this is a hard
question to answer.

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750