From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Fri, 5 Sep 2014 14:25:48 +0200 Subject: [U-Boot] [PATCH] dw_mmc: cleanups In-Reply-To: <201409051405.48296.marex@denx.de> References: <20140905104948.GA2511@amd> <201409051340.58383.marex@denx.de> <20140905115919.GA5473@amd> <201409051405.48296.marex@denx.de> Message-ID: <20140905122548.GB5473@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri 2014-09-05 14:05:48, Marek Vasut wrote: > On Friday, September 05, 2014 at 01:59:19 PM, Pavel Machek wrote: > > On Fri 2014-09-05 13:40:58, Marek Vasut wrote: > > > On Friday, September 05, 2014 at 12:49:48 PM, Pavel Machek wrote: > > > > dw_mmc driver was responding to errors with debug(). Change that to > > > > prinf so that any errors are immediately obvious. Also adjust english > > > > in comments. > > > > > > > > Signed-off-by: Pavel Machek > > > > > > > > diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c > > > > index 0df30bc..4c16e7f 100644 > > > > --- a/drivers/mmc/dw_mmc.c > > > > +++ b/drivers/mmc/dw_mmc.c > > > > @@ -177,14 +177,16 @@ static int dwmci_send_cmd(struct mmc *mmc, struct > > > > mmc_cmd *cmd, } > > > > > > > > } > > > > > > > > - if (i == retry) > > > > + if (i == retry) { > > > > + printf("dwmci_send_cmd: timeout..\n"); > > > > > > puts(), please fix globally. > > > > Won't. > > > > printf() is canonical way of printing, and is used in such way at 1000 > > places in u-boot. > > The agreement is to use puts() when there are no args attached to the print, > so that the code size is reduced. I did not make such agreement with you, and don't think obfuscating code with printf->puts conversion is a good idea. If there's codingstyle document I missed somewhere, please point me to it. If you think global conversion is a good idea, please do it, so that old code does not serve as a bad example. But I don't think it saves any size, compared to speed of serial line it does not save any time, either. Pavel PS: Sorry for flames on the mailing list, but marex explicitely asked me to take discussion there. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html