[U-Boot] [PATCH] dw_mmc: cleanups

Pavel Machek
2014-09-05T11:59:19Z

On Fri 2014-09-05 13:40:58, Marek Vasut wrote:
> On Friday, September 05, 2014 at 12:49:48 PM, Pavel Machek wrote:
> > dw_mmc driver was responding to errors with debug(). Change that to
> > prinf so that any errors are immediately obvious. Also adjust english
> > in comments.
> >
> > Signed-off-by: Pavel Machek <pavel@denx.de>
> >
> > diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> > index 0df30bc..4c16e7f 100644
> > --- a/drivers/mmc/dw_mmc.c
> > +++ b/drivers/mmc/dw_mmc.c
> > @@ -177,14 +177,16 @@ static int dwmci_send_cmd(struct mmc *mmc, struct
> > mmc_cmd *cmd, }
> > }
> >
> > - if (i == retry)
> > + if (i == retry) {
> > + printf("dwmci_send_cmd: timeout..\n");
>
> puts(), please fix globally.

Won't.

printf() is canonical way of printing, and is used in such way at 1000
places in u-boot.

But feel free to prepare patchv2 yourself if you think it is worth the
effort.

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html