From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dw_mmc: cleanups
Date: Fri, 5 Sep 2014 14:05:48 +0200 [thread overview]
Message-ID: <201409051405.48296.marex@denx.de> (raw)
In-Reply-To: <20140905115919.GA5473@amd>
On Friday, September 05, 2014 at 01:59:19 PM, Pavel Machek wrote:
> On Fri 2014-09-05 13:40:58, Marek Vasut wrote:
> > On Friday, September 05, 2014 at 12:49:48 PM, Pavel Machek wrote:
> > > dw_mmc driver was responding to errors with debug(). Change that to
> > > prinf so that any errors are immediately obvious. Also adjust english
> > > in comments.
> > >
> > > Signed-off-by: Pavel Machek <pavel@denx.de>
> > >
> > > diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> > > index 0df30bc..4c16e7f 100644
> > > --- a/drivers/mmc/dw_mmc.c
> > > +++ b/drivers/mmc/dw_mmc.c
> > > @@ -177,14 +177,16 @@ static int dwmci_send_cmd(struct mmc *mmc, struct
> > > mmc_cmd *cmd, }
> > >
> > > }
> > >
> > > - if (i == retry)
> > > + if (i == retry) {
> > > + printf("dwmci_send_cmd: timeout..\n");
> >
> > puts(), please fix globally.
>
> Won't.
>
> printf() is canonical way of printing, and is used in such way at 1000
> places in u-boot.
The agreement is to use puts() when there are no args attached to the print,
so that the code size is reduced.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-09-05 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 10:49 [U-Boot] [PATCH] dw_mmc: cleanups Pavel Machek
2014-09-05 11:40 ` Marek Vasut
2014-09-05 11:59 ` Pavel Machek
2014-09-05 12:05 ` Marek Vasut [this message]
2014-09-05 12:25 ` Pavel Machek
2014-09-11 2:06 ` Jaehoon Chung
2014-09-12 7:21 ` Chin Liang See
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409051405.48296.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox