public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] usb: dfu: add fullspeed support for DFU
Date: Thu, 11 Sep 2014 14:16:54 +0200	[thread overview]
Message-ID: <20140911141654.10f05d06@amdc2363> (raw)
In-Reply-To: <1410332101-26167-2-git-send-email-hs@denx.de>

Hi Heiko,

> DFU now can use also fullspeed.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Liu Bin <b-liu@ti.com>
> Cc: Lukas Stockmann <lukas.stockmann@siemens.com>
> 
> ---
> 
> - changes for v2:
>   - get rid of config option CONFIG_DFU_FULLSPEED as Bin Liu
>     suggested.
> ---
>  drivers/usb/gadget/f_dfu.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
> index 1145aab..dfa9f3b 100644
> --- a/drivers/usb/gadget/f_dfu.c
> +++ b/drivers/usb/gadget/f_dfu.c
> @@ -238,6 +238,7 @@ static inline void to_dfu_mode(struct f_dfu
> *f_dfu) {
>  	f_dfu->usb_function.strings = dfu_strings;
>  	f_dfu->usb_function.hs_descriptors = f_dfu->function;
> +	f_dfu->usb_function.descriptors = f_dfu->function;
>  	f_dfu->dfu_state = DFU_STATE_dfuIDLE;
>  }
>  
> @@ -245,6 +246,7 @@ static inline void to_runtime_mode(struct f_dfu
> *f_dfu) {
>  	f_dfu->usb_function.strings = NULL;
>  	f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
> +	f_dfu->usb_function.descriptors = dfu_runtime_descs;
>  }
>  
>  static int handle_upload(struct usb_request *req, u16 len)
> @@ -809,6 +811,7 @@ static int dfu_bind_config(struct
> usb_configuration *c) return -ENOMEM;
>  	f_dfu->usb_function.name = "dfu";
>  	f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
> +	f_dfu->usb_function.descriptors = dfu_runtime_descs;
>  	f_dfu->usb_function.bind = dfu_bind;
>  	f_dfu->usb_function.unbind = dfu_unbind;
>  	f_dfu->usb_function.set_alt = dfu_set_alt;

Test HW: Exynos 4412 - Trats2

This patch seems to not introduce any regressions, so

Tested-by: Lukasz Majewski <l.majewski@samsung.com>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  parent reply	other threads:[~2014-09-11 12:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10  6:54 [U-Boot] [PATCH v2 0/2] usb: dfu: am335x: allow dfu in fullspeed mode only Heiko Schocher
2014-09-10  6:55 ` [U-Boot] [PATCH v2 1/2] usb: dfu: add fullspeed support for DFU Heiko Schocher
2014-09-10 13:49   ` Bin Liu
2014-09-11 12:16   ` Lukasz Majewski [this message]
2014-09-15 10:26   ` Lukasz Majewski
2014-09-10  6:55 ` [U-Boot] [PATCH v2 2/2] arm: am335x: siemens board use in DFU mode fullspeed only Heiko Schocher
2014-09-15 10:26   ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140911141654.10f05d06@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox