From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] compiler.h: remove duplicated uninitialized_var
Date: Thu, 18 Sep 2014 17:59:32 -0400 [thread overview]
Message-ID: <20140918215932.GY25506@bill-the-cat> (raw)
In-Reply-To: <541AA860.8080101@myspectrum.nl>
On Thu, Sep 18, 2014 at 11:39:44AM +0200, Jeroen Hofstee wrote:
> Hello Masahiro,
>
> On 18-09-14 04:14, Masahiro Yamada wrote:
> >>Since clang has a different definition for uninitialized_var
> >>it will complain that it is redefined in include/compiler.h.
> >>Since these are already defined in linux/compiler.h just remove
> >>this instance.
> >>
> >>Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> >>Cc: Tom Rini <trini@ti.com>
> >>Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> >
> >
> >I don't mind this patch but it has made me realize
> >another problem.
> >
> >
> >We have both include/compiler.h and include/linux/compiler.h.
> >Some sources use tha former and others use the latter.
> >
> >I don't know how to use the right one in the right place.
>
> no me neither, although it seems arch / drivers tend to use
> linux/compiler.h more while tools include compiler.h more.
My first guess is that we can't as easily throw <linux/compiler.h> into
tools and thus need that around just for tools. Perhaps we should note
as much in <compiler.h> and fix regular code to use <linux/compiler.h> ?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140918/fde4b1a3/attachment.pgp>
next prev parent reply other threads:[~2014-09-18 21:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 18:33 [U-Boot] [PATCH 0/3] Fixes for FreeBSD / clang Jeroen Hofstee
2014-09-17 18:33 ` [U-Boot] [PATCH 1/3] compiler_gcc: do not redefine __gnu_attributes Jeroen Hofstee
2014-09-18 2:13 ` Masahiro Yamada
2014-09-18 9:15 ` Jeroen Hofstee
2014-09-18 9:58 ` Masahiro Yamada
2014-09-17 18:33 ` [U-Boot] [PATCH 2/3] README.clang: update FreeBSD instructions Jeroen Hofstee
2014-09-17 18:33 ` [U-Boot] [PATCH 3/3] compiler.h: remove duplicated uninitialized_var Jeroen Hofstee
2014-09-18 2:14 ` Masahiro Yamada
2014-09-18 9:39 ` Jeroen Hofstee
2014-09-18 21:59 ` Tom Rini [this message]
2014-09-25 14:46 ` [U-Boot] [U-Boot, " Tom Rini
2014-09-18 18:10 ` [U-Boot] [PATCH v2 1/3] compiler_gcc: prevent redefining attributes Jeroen Hofstee
2014-09-19 2:36 ` Masahiro Yamada
2014-09-25 14:46 ` [U-Boot] [U-Boot, v2, " Tom Rini
2014-09-21 8:20 ` [U-Boot] [PATCH v2 2/3] README.clang: update FreeBSD instructions Jeroen Hofstee
2014-09-25 14:46 ` [U-Boot] [U-Boot, v2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918215932.GY25506@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox