public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] socfpga: Enable DWMMC for SOCFPGA
Date: Fri, 19 Sep 2014 13:41:00 +0200	[thread overview]
Message-ID: <201409191341.00398.marex@denx.de> (raw)
In-Reply-To: <1411118904-22940-1-git-send-email-clsee@altera.com>

On Friday, September 19, 2014 at 11:28:23 AM, Chin Liang See wrote:
> To enable the DesignWare MMC controller driver support
> for SOCFPGA Cyclone5 dev kit
> 
> Signed-off-by: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@ti.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Wolfgang Denk <wd@denx.de>
> ---
>  include/configs/socfpga_cyclone5.h |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/include/configs/socfpga_cyclone5.h
> b/include/configs/socfpga_cyclone5.h index 32175b7..f9fafac 100644
> --- a/include/configs/socfpga_cyclone5.h
> +++ b/include/configs/socfpga_cyclone5.h
> @@ -252,6 +252,24 @@
>  /* Clocks source frequency to watchdog timer */
>  #define CONFIG_DW_WDT_CLOCK_KHZ		25000
> 
> +/*
> + * MMC support
> + */
> +#define CONFIG_MMC
> +#ifdef CONFIG_MMC
> +#define CONFIG_CMD_MMC
> +#define CONFIG_SDMMC_BASE		(SOCFPGA_SDMMC_ADDRESS)

This symbol doesn't exist.

> +#define CONFIG_SDMMC_HOST_HS

This symbol doesn't exist.

> +#define CONFIG_GENERIC_MMC		1

You don't actually need to define this to have a value.

> +#define CONFIG_DWMMC
> +#define CONFIG_SOCFPGA_DWMMC
> +#define CONFIG_SOCFPGA_DWMMC_FIFO_DEPTH	1024
> +#define CONFIG_SOCFPGA_DWMMC_DRVSEL	3
> +#define CONFIG_SOCFPGA_DWMMC_SMPSEL	0
> +#define CONFIG_BOUNCE_BUFFER
> +/* using smaller max blk cnt to avoid flooding the limited stack we have
> */ +#define CONFIG_SYS_MMC_MAX_BLK_COUNT     256

This is something I am wondering about (btw. you might have seen a FIXME tag in 
my repository right next to this code). Do we really need this in U-Boot or is 
this portion SPL specific ? Or do we even need this limit at all ?
[...]

Anyway, I will pick them in my tree and add a bit more magic sause to them , 
then re-post the whole series.

Best regards,
Marek Vasut

      reply	other threads:[~2014-09-19 11:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-19  9:28 [U-Boot] [PATCH] socfpga: Enable DWMMC for SOCFPGA Chin Liang See
2014-09-19 11:41 ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201409191341.00398.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox