From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 19 Sep 2014 13:41:00 +0200 Subject: [U-Boot] [PATCH] socfpga: Enable DWMMC for SOCFPGA In-Reply-To: <1411118904-22940-1-git-send-email-clsee@altera.com> References: <1411118904-22940-1-git-send-email-clsee@altera.com> Message-ID: <201409191341.00398.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, September 19, 2014 at 11:28:23 AM, Chin Liang See wrote: > To enable the DesignWare MMC controller driver support > for SOCFPGA Cyclone5 dev kit > > Signed-off-by: Chin Liang See > Cc: Dinh Nguyen > Cc: Pavel Machek > Cc: Marek Vasut > Cc: Tom Rini > Cc: Albert Aribaud > Cc: Wolfgang Denk > --- > include/configs/socfpga_cyclone5.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/include/configs/socfpga_cyclone5.h > b/include/configs/socfpga_cyclone5.h index 32175b7..f9fafac 100644 > --- a/include/configs/socfpga_cyclone5.h > +++ b/include/configs/socfpga_cyclone5.h > @@ -252,6 +252,24 @@ > /* Clocks source frequency to watchdog timer */ > #define CONFIG_DW_WDT_CLOCK_KHZ 25000 > > +/* > + * MMC support > + */ > +#define CONFIG_MMC > +#ifdef CONFIG_MMC > +#define CONFIG_CMD_MMC > +#define CONFIG_SDMMC_BASE (SOCFPGA_SDMMC_ADDRESS) This symbol doesn't exist. > +#define CONFIG_SDMMC_HOST_HS This symbol doesn't exist. > +#define CONFIG_GENERIC_MMC 1 You don't actually need to define this to have a value. > +#define CONFIG_DWMMC > +#define CONFIG_SOCFPGA_DWMMC > +#define CONFIG_SOCFPGA_DWMMC_FIFO_DEPTH 1024 > +#define CONFIG_SOCFPGA_DWMMC_DRVSEL 3 > +#define CONFIG_SOCFPGA_DWMMC_SMPSEL 0 > +#define CONFIG_BOUNCE_BUFFER > +/* using smaller max blk cnt to avoid flooding the limited stack we have > */ +#define CONFIG_SYS_MMC_MAX_BLK_COUNT 256 This is something I am wondering about (btw. you might have seen a FIXME tag in my repository right next to this code). Do we really need this in U-Boot or is this portion SPL specific ? Or do we even need this limit at all ? [...] Anyway, I will pick them in my tree and add a bit more magic sause to them , then re-post the whole series. Best regards, Marek Vasut