From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/7] Add a better USB keyboard polling method
Date: Sun, 21 Sep 2014 12:45:56 +0200 [thread overview]
Message-ID: <201409211245.56536.marex@denx.de> (raw)
In-Reply-To: <1411225272-13793-1-git-send-email-hdegoede@redhat.com>
On Saturday, September 20, 2014 at 05:01:05 PM, Hans de Goede wrote:
> Hi Marek,
>
> This time a patch-set for next :)
>
> Currently one can choose between 2 poll methods for usb keyboards, both of
> which are suboptimal. One option is to use control messages to get reports,
> which some devices (e.g. my kvm) do not like. The other option is to use
> interrupt urbs, but usb_submit_int_msg waits for the interrupt packet to
> show up, meaning that each poll takes 40 ms, slowing anything else down
> tremendously.
>
> This patch-sets adds a third method (only usable with ehci for now), which
> makes use of the int_queue concept in the ehci code. This allows us to
> submit an interrupt message, and then poll for the actual completion of
> this message giving us much lower latency then even the control message
> method (effectively this gives us 0 latency), while using standard
> interrupt messages which seems to keep keyboards much happier.
I'd be happy to just pick V2 as it would be. The patches look really nice.
Best regards,
Marek Vasut
prev parent reply other threads:[~2014-09-21 10:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 15:01 [U-Boot] [PATCH 0/7] Add a better USB keyboard polling method Hans de Goede
2014-09-20 15:01 ` [U-Boot] [PATCH 1/7] usb: ehci: Do not disable an already disabled periodic schedule Hans de Goede
2014-09-20 15:01 ` [U-Boot] [PATCH 2/7] usb: ehci: Move interrupt packet length check to create_int_queue Hans de Goede
2014-09-20 17:42 ` Michael Trimarchi
2014-09-21 17:53 ` Hans de Goede
2014-09-21 19:36 ` Marek Vasut
2014-09-21 20:00 ` Michael Trimarchi
2014-09-21 20:01 ` Marek Vasut
2014-09-20 15:01 ` [U-Boot] [PATCH 3/7] usb: ehci: Move cache invalidation to poll_int_queue Hans de Goede
2014-09-20 15:01 ` [U-Boot] [PATCH 4/7] usb: Make pollable int support available outside of ehci-hcd.c Hans de Goede
2014-09-20 15:01 ` [U-Boot] [PATCH 5/7] usb: kbd: Remove unused usb_kbd_generic_poll function Hans de Goede
2014-09-20 15:01 ` [U-Boot] [PATCH 6/7] usb: kbd: Cache pipe, interval and packetsize Hans de Goede
2014-09-20 17:53 ` Michael Trimarchi
2014-09-21 17:54 ` Hans de Goede
2014-09-20 15:01 ` [U-Boot] [PATCH 7/7] usb: kbd: Add (optional) support for using an interrupt queue for polling Hans de Goede
2014-09-20 15:18 ` Hans de Goede
2014-09-21 10:45 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409211245.56536.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox