From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavel Machek <pavel@denx.de>
Date: Mon, 22 Sep 2014 11:16:04 +0200
Subject: [U-Boot] [PATCH 31/51] fpga: altera: Make altera_validate
 return normal values
In-Reply-To: <1411305152-11690-4-git-send-email-marex@denx.de>
References: <1411304339-11348-1-git-send-email-marex@denx.de>
	<1411305152-11690-1-git-send-email-marex@denx.de>
	<1411305152-11690-4-git-send-email-marex@denx.de>
Message-ID: <20140922091604.GB15350@amd>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sun 2014-09-21 15:12:12, Marek Vasut wrote:
> Make the function return either 0 or -EINVAL, that is, normal
> expected error codes and success codes instead of true/false
> nonsense.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Tom Rini <trini@ti.com>
> Cc: Wolfgang Denk <wd@denx.de>

Acked-by: Pavel Machek <pavel@denx.de>

> @@ -133,7 +133,7 @@ int altera_info(Altera_desc *desc)
>  {
>  	int ret_val = FPGA_FAIL;
>  
> -	if (!altera_validate (desc, (char *)__func__)) {
> +	if (altera_validate (desc, (char *)__func__)) {
+       if (altera_validate(desc, (char *)__func__)) {

You have extra space there, checkpatch would be angry.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html