From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 23 Sep 2014 16:30:41 +0200 Subject: [U-Boot] [PATCH] i2c: mxs: Add I2C multibus support In-Reply-To: References: <1411470944-6147-1-git-send-email-marex@denx.de> <54215DF2.8050402@denx.de> Message-ID: <201409231630.41856.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, September 23, 2014 at 03:49:27 PM, Otavio Salvador wrote: > On Tue, Sep 23, 2014 at 8:48 AM, Heiko Schocher wrote: > > Hello Marek, > > > > Am 23.09.2014 13:15, schrieb Marek Vasut: > >> The i.MX28 has two I2C IP blocks, but the MXS I2C driver is hard-coded > >> to use the I2C block 0 . Add multibus support so we can use both I2C > >> busses as seen fit. > >> > >> Signed-off-by: Marek Vasut > >> Cc: Stefano Babic > >> --- > >> > >> drivers/i2c/mxs_i2c.c | 47 > >> > >> +++++++++++++++++++++++++++++++++++++---------- > >> > >> include/configs/mxs.h | 1 + > >> 2 files changed, 38 insertions(+), 10 deletions(-) > > > > Sorry, I have to NACK this patch. Please convert the driver for using > > the CONFIG_SYS_I2C framework, see for example the drivers/i2c/mxc_i2c.c > > driver, thanks! > > I think the conversion could be a follow up patch, I see no good > reason to block this patch as is. I disagree with you. Accepting this patch as is would only hinder progress toward the conversion and would set a bad example further down the line, leading only to more crap patches. Moreover, this is 2015.01 matter, so there is plenty of time for the rework to take place. Thus, I agree with Heiko. Best regards, Marek Vasut