From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] arm: socfpga: config: Enable USB support
Date: Wed, 24 Sep 2014 01:36:47 +0200 [thread overview]
Message-ID: <201409240136.47180.marex@denx.de> (raw)
In-Reply-To: <CADhT+wcCggB0vyLDtV-bWFkchCmLFaDznjLBRdgbRqvN_v53fA@mail.gmail.com>
On Wednesday, September 24, 2014 at 12:21:04 AM, Dinh Nguyen wrote:
> On Tue, Sep 23, 2014 at 2:55 PM, Dinh Nguyen
>
> <dinguyen@opensource.altera.com> wrote:
> > On Sun, 21 Sep 2014, Marek Vasut wrote:
> >> Enable support for the DWC2 USB controller.
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Chin Liang See <clsee@altera.com>
> >> Cc: Dinh Nguyen <dinguyen@altera.com>
> >> Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> >> Cc: Tom Rini <trini@ti.com>
> >> Cc: Wolfgang Denk <wd@denx.de>
> >> Cc: Pavel Machek <pavel@denx.de>
> >> ---
> >>
> >> include/configs/socfpga_cyclone5_common.h | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/include/configs/socfpga_cyclone5_common.h
> >> b/include/configs/socfpga_cyclone5_common.h index 49504dc..3f8f91f
> >> 100644
> >> --- a/include/configs/socfpga_cyclone5_common.h
> >> +++ b/include/configs/socfpga_cyclone5_common.h
> >> @@ -157,6 +157,14 @@
> >>
> >> #define CONFIG_BAUDRATE 115200
> >>
> >> /*
> >>
> >> + * USB
> >> + */
> >> +#ifdef CONFIG_CMD_USB
> >> +#define CONFIG_USB_DWC2
> >> +#define CONFIG_USB_STORAGE
> >
> > Don't you also need:
> >
> > #define CONFIG_USB_DWC2_REG_ADDR 0xffb40000
> >
> > for the base address for the USB1 on SOCFPGA?
>
> Now that I saw patch 50/51 "arm: socfpga: Split SoCFPGA configuration",
> I think these defines should go into socfpga_cyclone5.h
Yeah, the board specific goes into socfpga_cyclone5.h , since that's de-facto
support for the SoCDK board. The "generic" part goes into
socfpga_cyclone5_common.h .
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-09-23 23:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 13:13 [U-Boot] [PATCH 0/3] usb: dwc2: Add and enable DWC2 driver Marek Vasut
2014-09-21 13:13 ` [U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP block Marek Vasut
2014-09-22 9:40 ` Pavel Machek
2014-09-22 10:53 ` Marek Vasut
2014-09-30 11:57 ` Pavel Machek
2014-09-23 21:59 ` Dinh Nguyen
2014-09-26 7:29 ` Marek Vasut
2014-09-26 15:01 ` Dinh Nguyen
2014-09-26 15:59 ` Marek Vasut
2014-09-24 3:31 ` Stephen Warren
2014-09-24 9:25 ` Marek Vasut
2014-09-24 15:37 ` Stephen Warren
2014-09-24 17:47 ` Marek Vasut
2014-09-21 13:13 ` [U-Boot] [PATCH 2/3] arm: socfpga: config: Enable USB support Marek Vasut
2014-09-23 19:55 ` Dinh Nguyen
2014-09-23 20:16 ` Marek Vasut
2014-09-23 22:21 ` Dinh Nguyen
2014-09-23 23:36 ` Marek Vasut [this message]
2014-09-21 13:13 ` [U-Boot] [PATCH 3/3] arm: rpi: Enable USB support on RPi Marek Vasut
2014-09-29 7:02 ` [U-Boot] [PATCH 0/3] usb: dwc2: Add and enable DWC2 driver Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409240136.47180.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox