From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 24 Sep 2014 11:25:38 +0200 Subject: [U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP block In-Reply-To: <54223B0E.8060906@wwwdotorg.org> References: <1411305204-11731-1-git-send-email-marex@denx.de> <1411305204-11731-2-git-send-email-marex@denx.de> <54223B0E.8060906@wwwdotorg.org> Message-ID: <201409241125.38194.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, September 24, 2014 at 05:31:26 AM, Stephen Warren wrote: > On 09/21/2014 07:13 AM, Marek Vasut wrote: > > From: Oleksandr Tymoshenko > > > > This is the USB host controller used on the Altera SoCFPGA and Raspbery > > Pi. > > > > This code has three checkpatch warnings, but to make sure it stays at > > least readable and clear, these are not fixed. These bugs are in the USB > > request handling combinatorial logic, so any abstracting of those is out > > of question. > > > > Tested on DENX MCV (Altera SoCFPGA 5CSFXC6C6U23C8N) and RPi B+ (BCM2835). > > Patches 1, 3, > Tested-by: Stephen Warren > > That said, I needed "ARM: rpi_b: query internal MAC address from > firmware" to get the MAC address set up correctly. I obviously used that > when testing. I guess I should send that patch:-) > > Patch 3, > Acked-by: Stephen Warren > > > Signed-off-by: Oleksandr Tymoshenko > > Signed-off-by: Stephen Warren > > Given this patch has quite a few changes relative to what Oleksandr or I > sent, it might be nice to include some notes in the commit description > re: what you changed. > > [Marek, fiddled with the frob ...] For the most part, it's only based on what Oleksander sent. You can probably make a diff between versions, but it will look like a complete rewrite there. > > Signed-off-by: Marek Vasut > > > > README | 3 + > > drivers/usb/host/Makefile | 3 + > > drivers/usb/host/dwc2.c | 952 > > ++++++++++++++++++++++++++++++++++++++++++++++ drivers/usb/host/dwc2.h > > | 784 ++++++++++++++++++++++++++++++++++++++ > > In the version Oleksandr sent, there was some header that defined the HW > registers that had some problematic Synopsis license. Did dwc2.h come > from the Linux kernel? If that is the case, aren't we supposed to say > which kernel commit and path it came from? Yes, the problematic file is dropped completely. The dwc2.h was written from scratch. Best regards, Marek Vasut