From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Wed, 24 Sep 2014 17:38:07 +0200 Subject: [U-Boot] [PATCH 50/51] arm: socfpga: Split SoCFPGA configuration In-Reply-To: References: <1411304339-11348-1-git-send-email-marex@denx.de> <1411305152-11690-1-git-send-email-marex@denx.de> <1411305152-11690-23-git-send-email-marex@denx.de> Message-ID: <20140924153807.GA9563@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi! > > From: Pavel Machek > > > > Split the SoCFPGA configuration into SoC-specific part which is > > common for all boards (socfpga_cyclone5_common.h) and a board > > specific part. There is currently only one board, which is the > > generic SoCFPGA board (socfpga_cyclone5.h), but there are more > > to come. > > > > This is necessary due to various features of the boards, which > > unfortunatelly cannot be autodetected. > > > > Signed-off-by: Marek Vasut > > Cc: Chin Liang See > > Cc: Dinh Nguyen > > Cc: Albert Aribaud > > Cc: Tom Rini > > Cc: Wolfgang Denk > > Cc: Pavel Machek > > --- > > include/configs/socfpga_cyclone5.h | 211 ++---------------------------- > > include/configs/socfpga_cyclone5_common.h | 196 +++++++++++++++++++++++++++ > > 2 files changed, 207 insertions(+), 200 deletions(-) > > create mode 100644 include/configs/socfpga_cyclone5_common.h > > Thanks for taking a stab at this, but I think it makes more sense to have > socfpga_commoh.h and socfpga_cyclone5.h. The _common file can have most of > the common settings for u-boot, while _cyclone5 will have the base addresses > for all the various IP blocks. Then once everything is done for Cyclone5, we > can add support for the Arria5 SOC by just adding socfpga_arria5.h. socfpga_common.h sounds like a good name. But I wonder if socfpga_cyclone5.h should be named socfpga_cyclone5_socdk.h ? Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html