From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v2, 1/3] compiler_gcc: prevent redefining attributes
Date: Thu, 25 Sep 2014 10:46:21 -0400 [thread overview]
Message-ID: <20140925144621.GL25506@bill-the-cat> (raw)
In-Reply-To: <1411063827-10068-1-git-send-email-jeroen@myspectrum.nl>
On Thu, Sep 18, 2014 at 08:10:27PM +0200, Jeroen Hofstee wrote:
> The libc headers on FreeBSD and likely related projects as well contain an
> header file, cdefs.h which provides similiar functionality as linux/compiler.h.
> It provides compiler independent defines like __weak __packed, to allow
> compiling with multiple compilers which might have a different syntax for such
> extension.
>
> Since that header file is included in multiple standard headers, like stddef.h
> and stdarg.h, multiple definitions of those defines will be present if both are
> included. When compiling u-boot the compiler will warn about it hundreds of
> times since e.g. common.h will include both files indirectly.
>
> commit 7ea50d52849fe8ffa5b5b74c979b60b1045d6fc9 "compiler_gcc: do not redefine
> __gnu_attributes" prevented such redefinitions, but this was undone by commit
> fb8ffd7cfc68b3dc44e182356a207d784cb30b34 "compiler*.h: sync
> include/linux/compiler*.h with Linux 3.16".
>
> Add the checks back where necessary to prevent such warnings.
>
> As the original patch this checkpatch warning is ignored:
> "WARNING: Adding new packed members is to be done with care"
>
> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Tom Rini <trini@ti.com>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Acked-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140925/2e1dccfb/attachment.pgp>
next prev parent reply other threads:[~2014-09-25 14:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 18:33 [U-Boot] [PATCH 0/3] Fixes for FreeBSD / clang Jeroen Hofstee
2014-09-17 18:33 ` [U-Boot] [PATCH 1/3] compiler_gcc: do not redefine __gnu_attributes Jeroen Hofstee
2014-09-18 2:13 ` Masahiro Yamada
2014-09-18 9:15 ` Jeroen Hofstee
2014-09-18 9:58 ` Masahiro Yamada
2014-09-17 18:33 ` [U-Boot] [PATCH 2/3] README.clang: update FreeBSD instructions Jeroen Hofstee
2014-09-17 18:33 ` [U-Boot] [PATCH 3/3] compiler.h: remove duplicated uninitialized_var Jeroen Hofstee
2014-09-18 2:14 ` Masahiro Yamada
2014-09-18 9:39 ` Jeroen Hofstee
2014-09-18 21:59 ` Tom Rini
2014-09-25 14:46 ` [U-Boot] [U-Boot, " Tom Rini
2014-09-18 18:10 ` [U-Boot] [PATCH v2 1/3] compiler_gcc: prevent redefining attributes Jeroen Hofstee
2014-09-19 2:36 ` Masahiro Yamada
2014-09-25 14:46 ` Tom Rini [this message]
2014-09-21 8:20 ` [U-Boot] [PATCH v2 2/3] README.clang: update FreeBSD instructions Jeroen Hofstee
2014-09-25 14:46 ` [U-Boot] [U-Boot, v2, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140925144621.GL25506@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox