From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 1/3] usb: eth: fix Makefile
Date: Fri, 26 Sep 2014 10:12:58 +0200 [thread overview]
Message-ID: <201409261012.58881.marex@denx.de> (raw)
In-Reply-To: <1411718929-23048-1-git-send-email-rgriessl@cit-ec.uni-bielefeld.de>
On Friday, September 26, 2014 at 10:08:47 AM, Rene Griessl wrote:
> fix issue as discussed with Marek Vasut
Now I'm twice as famous ;-)
But in fact, you should actually explain the change you did in the commit
message (aka. something along the lines of the ifdef being useless and that
using simpler and consistent notation is fine).
> Signed-off-by: Rene Griessl <rgriessl@cit-ec.uni-bielefeld.de>
> ---
> drivers/usb/eth/Makefile | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/eth/Makefile b/drivers/usb/eth/Makefile
> index 94551c4..e6ae9f1 100644
> --- a/drivers/usb/eth/Makefile
> +++ b/drivers/usb/eth/Makefile
> @@ -5,8 +5,6 @@
>
> # new USB host ethernet layer dependencies
> obj-$(CONFIG_USB_HOST_ETHER) += usb_ether.o
> -ifdef CONFIG_USB_ETHER_ASIX
> -obj-y += asix.o
> -endif
> +obj-$(CONFIG_USB_ETHER_ASIX) += asix.o
> obj-$(CONFIG_USB_ETHER_MCS7830) += mcs7830.o
> obj-$(CONFIG_USB_ETHER_SMSC95XX) += smsc95xx.o
Best regards,
Marek Vasut
prev parent reply other threads:[~2014-09-26 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 8:08 [U-Boot] [PATCH V3 1/3] usb: eth: fix Makefile Rene Griessl
2014-09-26 8:08 ` [U-Boot] [PATCH V3 2/3] usb: eth: add ASIX AX88179 DRIVER Rene Griessl
2014-09-26 8:23 ` Marek Vasut
2014-09-26 9:35 ` René Griessl
2014-09-26 13:47 ` Marek Vasut
2014-09-26 15:42 ` René Griessl
2014-09-26 15:49 ` Marek Vasut
2014-10-06 17:45 ` Andy Pont
2014-10-27 9:38 ` René Griessl
2014-09-26 8:08 ` [U-Boot] [PATCH V3 3/3] usb: eth: enable AX88179 DRIVER for ARNDALE 5250 Rene Griessl
2014-09-26 8:12 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409261012.58881.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox