public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4] ARM: mx6: Add support for Kosagi Novena
Date: Sat, 27 Sep 2014 22:29:44 +0200	[thread overview]
Message-ID: <201409272229.44301.marex@denx.de> (raw)
In-Reply-To: <aaf350a9-c3c0-43e0-845e-f26de0402fb4@email.android.com>

On Saturday, September 27, 2014 at 06:46:24 PM, Sean Cross wrote:
> I asked Bunnie about this, and the routing is 50 ohms.
> 
> On 24 September, 2014 5:40:59 pm GMT+08:00, Marek Vasut <marex@denx.de> wrote:
> >On Wednesday, September 24, 2014 at 04:46:42 AM, Nikolay Dimitrov
> >
> >wrote:
> >> Hi Marek,
> >> 
> >> Following are some comments about FEC Ethernet:
> >> 
> >> On 09/23/2014 01:18 PM, Marek Vasut wrote:
> >> > +#define ENET_PAD_CTRL						\
> >> > +	(PAD_CTL_PKE | PAD_CTL_PUE |				\
> >> > +	PAD_CTL_PUS_100K_UP | PAD_CTL_SPEED_MED	  |		\
> >> > +	PAD_CTL_DSE_40ohm   | PAD_CTL_HYS)
> >> > +
> >> 
> >> PAD_CTL_SPEED_MED falls on reserved bits (7-6).

Fixed.

[...]

> >> > +
> >> > +	gpio_direction_output(IMX_GPIO_NR(3, 23), 0);
> >> > +	gpio_direction_output(IMX_GPIO_NR(6, 30), 1);
> >> > +	gpio_direction_output(IMX_GPIO_NR(6, 25), 1);
> >> > +	gpio_direction_output(IMX_GPIO_NR(6, 27), 1);
> >> > +	gpio_direction_output(IMX_GPIO_NR(6, 28), 1);
> >> > +	gpio_direction_output(IMX_GPIO_NR(6, 29), 1);
> >> > +	gpio_direction_output(IMX_GPIO_NR(6, 24), 1);
> >> > +}
> >> 
> >> I think that setting the iomuxes immediately one after the other
> >
> >doesn't
> >
> >> achieve the intended goal. After the 2nd iomux setup, the pads are
> >> connected to the FEC, not to the GPIOs.

Good point, moved the second mux below the GPIO settings.

But what about the reset timing?

Best regards,
Marek Vasut

  reply	other threads:[~2014-09-27 20:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 10:18 [U-Boot] [PATCH V4] ARM: mx6: Add support for Kosagi Novena Marek Vasut
2014-09-23 23:57 ` Nikolay Dimitrov
2014-09-24  9:37   ` Marek Vasut
2014-09-24 11:03     ` Nikolay Dimitrov
2014-09-24 11:15       ` Marek Vasut
2014-09-24  2:46 ` Nikolay Dimitrov
2014-09-24  9:40   ` Marek Vasut
2014-09-27 16:46     ` Sean Cross
2014-09-27 20:29       ` Marek Vasut [this message]
2014-10-06 15:35     ` Sean Cross
2014-10-06 15:57       ` Marek Vasut
2014-10-06 12:50   ` Nikolay Dimitrov
2014-10-06 14:00     ` Marek Vasut
2014-10-09  0:50       ` Nikolay Dimitrov
2014-10-09  0:54         ` Marek Vasut
2014-09-28  4:44 ` Nikolay Dimitrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201409272229.44301.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox