From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 27 Sep 2014 22:29:44 +0200 Subject: [U-Boot] [PATCH V4] ARM: mx6: Add support for Kosagi Novena In-Reply-To: References: <1411467483-5766-1-git-send-email-marex@denx.de> <201409241140.59419.marex@denx.de> Message-ID: <201409272229.44301.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday, September 27, 2014 at 06:46:24 PM, Sean Cross wrote: > I asked Bunnie about this, and the routing is 50 ohms. > > On 24 September, 2014 5:40:59 pm GMT+08:00, Marek Vasut wrote: > >On Wednesday, September 24, 2014 at 04:46:42 AM, Nikolay Dimitrov > > > >wrote: > >> Hi Marek, > >> > >> Following are some comments about FEC Ethernet: > >> > >> On 09/23/2014 01:18 PM, Marek Vasut wrote: > >> > +#define ENET_PAD_CTRL \ > >> > + (PAD_CTL_PKE | PAD_CTL_PUE | \ > >> > + PAD_CTL_PUS_100K_UP | PAD_CTL_SPEED_MED | \ > >> > + PAD_CTL_DSE_40ohm | PAD_CTL_HYS) > >> > + > >> > >> PAD_CTL_SPEED_MED falls on reserved bits (7-6). Fixed. [...] > >> > + > >> > + gpio_direction_output(IMX_GPIO_NR(3, 23), 0); > >> > + gpio_direction_output(IMX_GPIO_NR(6, 30), 1); > >> > + gpio_direction_output(IMX_GPIO_NR(6, 25), 1); > >> > + gpio_direction_output(IMX_GPIO_NR(6, 27), 1); > >> > + gpio_direction_output(IMX_GPIO_NR(6, 28), 1); > >> > + gpio_direction_output(IMX_GPIO_NR(6, 29), 1); > >> > + gpio_direction_output(IMX_GPIO_NR(6, 24), 1); > >> > +} > >> > >> I think that setting the iomuxes immediately one after the other > > > >doesn't > > > >> achieve the intended goal. After the 2nd iomux setup, the pads are > >> connected to the FEC, not to the GPIOs. Good point, moved the second mux below the GPIO settings. But what about the reset timing? Best regards, Marek Vasut