[U-Boot] [PATCH] tools: mkimage can read input on /dev/stdin

Julien Castets
2014-09-28T00:16:14Z

Thanks for your comments,

On Sat, Sep 27, 2014 at 11:56 PM, Wolfgang Denk <wd@denx.de> wrote:
> Can you please provide values for the size of the binary and the
> execution time?

Without the patch, with mmap:
$> dd if=/dev/zero of=test bs=1M count=10
$> time ./mkimage -A arm -O linux -a 0 -e 0 -T script -C none -n
'test' -d test test_out
...
real 0m0.168s
user 0m0.027s
sys 0m0.023s

With the patch, with read:
$> dd if=/dev/zero of=test bs=1M count=10
$> time ./mkimage -A arm -O linux -a 0 -e 0 -T script -C none -n
'test' -d test test_out
...
real 0m0.160s
user 0m0.025s
sys 0m0.016s

In both cases, the binary mkimage size is 144k bytes (147333 with
mmap, 147421 with read). Compiled with make sandbox_defconfig and
make_tools.

> It's not really critical, but I'd like to understand the impact of
> your changes. You use case is pretty exotic, so it seems a valid
> question to me to try to understand what the extended functionality
> costs.

I understand the use case, in its globality, is pretty exotic.
However, I don't really get why giving /dev/stdin as input is.

Regards,
--
Julien Castets