From: Pavel Machek <pavel@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP block
Date: Tue, 30 Sep 2014 13:57:06 +0200 [thread overview]
Message-ID: <20140930115706.GA25087@amd> (raw)
In-Reply-To: <201409221253.14048.marex@denx.de>
Hi!
> > > + case (USB_REQ_GET_DESCRIPTOR << 8) | USB_DIR_IN | USB_TYPE_CLASS:
> > > + {
> > > + __u32 temp = 0x00000001;
> >
> > temp is never writtenn to. Can you just write 1 instead of it?
>
> I added a comment. This is the root port config, so it should be tweakable
> in case there is some mutated DWC2 core.
Ok.
> > > + /* TODO: no endless loop */
> > > + while (1) {
> > > + hcint_new = readl(&hc_regs->hcint);
> > > + if (hcint != hcint_new)
> > > + hcint = hcint_new;
> >
> > What is going on here?
>
> What do you mean ? The loop ?
hcint is set to hcint_new in rather interesting way. The if() should
not be needed, but maybe something else is wrong with the code.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-09-30 11:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 13:13 [U-Boot] [PATCH 0/3] usb: dwc2: Add and enable DWC2 driver Marek Vasut
2014-09-21 13:13 ` [U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP block Marek Vasut
2014-09-22 9:40 ` Pavel Machek
2014-09-22 10:53 ` Marek Vasut
2014-09-30 11:57 ` Pavel Machek [this message]
2014-09-23 21:59 ` Dinh Nguyen
2014-09-26 7:29 ` Marek Vasut
2014-09-26 15:01 ` Dinh Nguyen
2014-09-26 15:59 ` Marek Vasut
2014-09-24 3:31 ` Stephen Warren
2014-09-24 9:25 ` Marek Vasut
2014-09-24 15:37 ` Stephen Warren
2014-09-24 17:47 ` Marek Vasut
2014-09-21 13:13 ` [U-Boot] [PATCH 2/3] arm: socfpga: config: Enable USB support Marek Vasut
2014-09-23 19:55 ` Dinh Nguyen
2014-09-23 20:16 ` Marek Vasut
2014-09-23 22:21 ` Dinh Nguyen
2014-09-23 23:36 ` Marek Vasut
2014-09-21 13:13 ` [U-Boot] [PATCH 3/3] arm: rpi: Enable USB support on RPi Marek Vasut
2014-09-29 7:02 ` [U-Boot] [PATCH 0/3] usb: dwc2: Add and enable DWC2 driver Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930115706.GA25087@amd \
--to=pavel@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox