From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Tue, 30 Sep 2014 13:57:06 +0200 Subject: [U-Boot] [PATCH 1/3] usb: dwc2: Add driver for Synopsis DWC2 USB IP block In-Reply-To: <201409221253.14048.marex@denx.de> References: <1411305204-11731-1-git-send-email-marex@denx.de> <1411305204-11731-2-git-send-email-marex@denx.de> <20140922094036.GC15350@amd> <201409221253.14048.marex@denx.de> Message-ID: <20140930115706.GA25087@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi! > > > + case (USB_REQ_GET_DESCRIPTOR << 8) | USB_DIR_IN | USB_TYPE_CLASS: > > > + { > > > + __u32 temp = 0x00000001; > > > > temp is never writtenn to. Can you just write 1 instead of it? > > I added a comment. This is the root port config, so it should be tweakable > in case there is some mutated DWC2 core. Ok. > > > + /* TODO: no endless loop */ > > > + while (1) { > > > + hcint_new = readl(&hc_regs->hcint); > > > + if (hcint != hcint_new) > > > + hcint = hcint_new; > > > > What is going on here? > > What do you mean ? The loop ? hcint is set to hcint_new in rather interesting way. The if() should not be needed, but maybe something else is wrong with the code. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html