[U-Boot] [PATCH 1/3] usb: gadget: fastboot: add max-download-size variable

Marek Vasut
2014-10-02T02:37:56Z

On Wednesday, October 01, 2014 at 10:38:57 PM, Steve Rae wrote:
> On 14-09-30 12:05 PM, Eric Nelson wrote:
> > Current Android Fastboot seems to use 'max-download-size' instead
> > of 'downloadsize' variable to indicate the maximum size of sparse
> > segments.
> >
> > See function get_target_sparse_limit() in file fastboot/fastboot.c
> >
> > in the AOSP:
> > https://android.googlesource.com/platform/system/core/+/master
> >
> > Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> > ---
> >
> > drivers/usb/gadget/f_fastboot.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/f_fastboot.c
> > b/drivers/usb/gadget/f_fastboot.c index 38c0965..f970f89 100644
> > --- a/drivers/usb/gadget/f_fastboot.c
> > +++ b/drivers/usb/gadget/f_fastboot.c
> > @@ -351,7 +351,8 @@ static void cb_getvar(struct usb_ep *ep, struct
> > usb_request *req)
> >
> > strncat(response, FASTBOOT_VERSION, chars_left);
> >
> > } else if (!strcmp_l1("bootloader-version", cmd)) {
> >
> > strncat(response, U_BOOT_VERSION, chars_left);
> >
> > - } else if (!strcmp_l1("downloadsize", cmd)) {
> > + } else if (!strcmp_l1("downloadsize", cmd) ||
> > + !strcmp_l1("max-download-size", cmd)) {
> >
> > char str_num[12];
> >
> > sprintf(str_num, "%08x", CONFIG_USB_FASTBOOT_BUF_SIZE);
>
> (the host version of fastboot that I'm using requires this change!)
> Tested-by: Steve Rae <srae@broadcom.com>

Wow, so the previous code that was accepted was broken ? Did you know about that
breakage ?

Best regards,
Marek Vasut