[U-Boot] [PATCH V4] ARM: mx6: Add support for Kosagi Novena

Marek Vasut
2014-09-24T09:37:25Z

On Wednesday, September 24, 2014 at 01:57:50 AM, Nikolay Dimitrov wrote:
> Hi Marek,
>
> Some comments about SPI:
>
> On 09/23/2014 01:18 PM, Marek Vasut wrote:
> > +/*
> > + * SPI
> > + */
> > +#ifdef CONFIG_MXC_SPI
> > +static iomux_v3_cfg_t ecspi1_pads[] = {
> > + /* SS1 */
> > + MX6_PAD_EIM_D19__GPIO3_IO19 | MUX_PAD_CTRL(SPI_PAD_CTRL),
> > + MX6_PAD_EIM_D17__ECSPI1_MISO | MUX_PAD_CTRL(SPI_PAD_CTRL),
> > + MX6_PAD_EIM_D18__ECSPI1_MOSI | MUX_PAD_CTRL(SPI_PAD_CTRL),
> > + MX6_PAD_EIM_D16__ECSPI1_SCLK | MUX_PAD_CTRL(SPI_PAD_CTRL),
> > +};
> > +
> > +static void novena_spl_setup_iomux_spi(void)
> > +{
> > + imx_iomux_v3_setup_multiple_pads(ecspi1_pads, ARRAY_SIZE(ecspi1_pads));
> > + gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1);
> > +}
> > +#else
> > +static void novena_spl_setup_iomux_spi(void) {}
> > +#endif
>
> I checked the schematic and didn't saw any usage of ECSPI1. In addition,
> these pads (EIM D16/17/18/19) are used by other interfaces. Can you
> please also double-check this?

Good find, I'll zap this part. Sean, why was this in the original Novena U-Boot
source?

Also, can you please review the entire thing so I don't have to retest and
resend the patch every day with one minor modification each time?

Thanks

Best regards,
Marek Vasut