From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Tue, 7 Oct 2014 19:51:57 +0200 Subject: [U-Boot] [PATCH 2/2] usb: eth: smsc95xx: Add EEPROM access support In-Reply-To: <20141007153540.322d3264@avionic-0020> References: <1412673577-8113-1-git-send-email-alban.bedel@avionic-design.de> <1412673577-8113-2-git-send-email-alban.bedel@avionic-design.de> <20141007122208.GA22589@amd> <20141007153540.322d3264@avionic-0020> Message-ID: <20141007175157.GB22589@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi! > > > +static u8 eeprom_defaults[] = { > > > + /* 0x00 */ > > > + 0xA5, /* Signature */ > > > + 0xFF, 0xFF, /* MAC bytes 0-1 */ > > > + 0xFF, 0xFF, /* MAC bytes 2-3 */ > > > + 0xFF, 0xFF, /* MAC bytes 4-5 */ > > > > Normally, we use all zeros for unset...? > > That's what the controller use when the EEPROM hasn't been programmed, > but I'll change it to all 0. Aha, if this is in-controller-default, don't change it. But comment explaining where this comes from would be nice. Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html