From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Wed, 8 Oct 2014 22:35:54 +0200 Subject: [U-Boot] [PATCH v1 1/1] fs: fat/ext4/sandbox: Deal with files > 2GB in ls and size commands In-Reply-To: <1412799828-3412-1-git-send-email-suriyan.r@gmail.com> References: <1412799828-3412-1-git-send-email-suriyan.r@gmail.com> Message-ID: <20141008203554.GA9751@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed 2014-10-08 13:23:48, Suriyan Ramasami wrote: > The commands fatls/ext4ls give -ve values when dealing with files > 2GB. > The commands fatsize/ext4size do not update the variable filesize for > these files. > > To deal with this, the functions *_size have been modified to take a second > parameter of type "* off_t" which is then populated. The return value of the > *_size function is then only used to determine error conditions. Would not it be better to simply change return type of affected functions to off_t? (If off_t is unsigned, invent signed off_t. It is still nicer than extra parameter.) > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html