From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] print true board names on socfpga
Date: Thu, 9 Oct 2014 01:35:22 +0200 [thread overview]
Message-ID: <201410090135.22389.marex@denx.de> (raw)
In-Reply-To: <20141008230433.GB15821@amd>
On Thursday, October 09, 2014 at 01:04:33 AM, Pavel Machek wrote:
> On Thu 2014-10-09 00:55:59, Albert ARIBAUD wrote:
> > Hi Pavel,
> >
> > On Thu, 9 Oct 2014 00:48:12 +0200, Pavel Machek <pavel@denx.de> wrote:
> > > On Thu 2014-10-09 00:24:34, Marek Vasut wrote:
> > > > On Thursday, October 09, 2014 at 12:12:28 AM, Pavel Machek wrote:
> > > > > On Thu 2014-10-09 00:07:04, Marek Vasut wrote:
> > > > > > On Wednesday, October 08, 2014 at 11:59:11 PM, Pavel Machek wrote:
> > > > > > > Make boards with Altera Socfpga print real board names.
> > > > > > >
> > > > > > > Signed-off-by: Pavel Machek <pavel@denx.de>
> > > > > >
> > > > > > Please wait with this one until the boards really reach mainline.
> > > > > > Also, the patch is missing tags in the subject, please add them
> > > > > > in.
> > > > >
> > > > > I wanted you to apply it to your tree. That way, the boards reach
> > > > > mainline with right names...
> > > >
> > > > What kind of names are you referring to ? Also, I see the CC list is
> > > > also broken
> > > >
> > > > :(
> > >
> > > Read the patch.
> > >
> > > Currently, u-boot prints confusing board names during boot.
> >
> > I'm not sure I understand either what the patch does. It touches
> > board/altera/socfpga/socfpga_cyclone5.c, which, AFAIU, is specific to
> > one single board. So, in this patch, CONFIG_BOARD_NAME can only contain
> > the Cyclone5 board name. Does any other board use this file with a
> > different CONFIG_BOARD_NAME?
>
> On marex's branch from 20141007
> (e8e77ee38da8760d0fa3ebdae37924db71f1e496):
>
> pavel at amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c
> #include "../../altera/socfpga/socfpga_cyclone5.c"
>
> Initial patch even said it is against Marek's tree...
U-Boot-socfpga shows this:
$ git show e8e77ee38da8760d0fa3ebdae37924db71f1e496
fatal: bad object e8e77ee38da8760d0fa3ebdae37924db71f1e496
Now I am really thoroughly confused, sorry.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-10-08 23:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 21:59 [U-Boot] [PATCH] print true board names on socfpga Pavel Machek
2014-10-08 22:07 ` Marek Vasut
2014-10-08 22:12 ` Pavel Machek
2014-10-08 22:24 ` Marek Vasut
2014-10-08 22:48 ` Pavel Machek
2014-10-08 22:55 ` Albert ARIBAUD
2014-10-08 23:04 ` Pavel Machek
2014-10-08 23:22 ` Albert ARIBAUD
2014-10-09 0:20 ` Pavel Machek
2014-10-08 23:35 ` Marek Vasut [this message]
2014-10-09 0:07 ` Pavel Machek
2014-10-08 23:34 ` Marek Vasut
2014-10-09 0:16 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201410090135.22389.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox