From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ARM: mxs: tools: Add support for boot progress display flag
Date: Thu, 9 Oct 2014 02:08:51 +0200 [thread overview]
Message-ID: <201410090208.51197.marex@denx.de> (raw)
In-Reply-To: <1412812704-4704-1-git-send-email-lexszero@gmail.com>
On Thursday, October 09, 2014 at 01:58:24 AM, Alexey Ignatov wrote:
> mkimage -T mxs now support new flag in config file:
> DISPLAYPROGRESS - makes boot process print HTLLC characters for each
> BootROM instruction.
>
> Signed-off-by: Alexey Ignatov <lexszero@gmail.com>
Hi!
[...]
> diff --git a/tools/mxsimage.h b/tools/mxsimage.h
> index 6cd59d2..9c61b4c 100644
> --- a/tools/mxsimage.h
> +++ b/tools/mxsimage.h
> @@ -81,8 +81,9 @@ struct sb_boot_image_header {
> #define SB_VERSION_MAJOR 1
> #define SB_VERSION_MINOR 1
>
> -/* Enable to HTLLC verbose boot report. */
> -#define SB_IMAGE_FLAG_VERBOSE (1 << 0)
> +/* Enable to HTLLC boot report. */
> +#define SB_IMAGE_FLAG_DISPLAY_PROGRESS (1 << 0)
> +#define SB_IMAGE_FLAGS_MASK (SB_IMAGE_FLAG_DISPLAY_PROGRESS)
There's no need for the () around the value. Fix this in V3 and add:
Reviewed-by: Marek Vasut <marex@denx.de>
Also please CC Stefano (now on CC), so he can pick V3 of this.
Thank you!
Best regards,
Marek Vasut
parent reply other threads:[~2014-10-09 0:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1412812704-4704-1-git-send-email-lexszero@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201410090208.51197.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox