public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] ARM: mxs: tools: Add support for boot progress display flag
       [not found] <1412812704-4704-1-git-send-email-lexszero@gmail.com>
@ 2014-10-09  0:08 ` Marek Vasut
  0 siblings, 0 replies; only message in thread
From: Marek Vasut @ 2014-10-09  0:08 UTC (permalink / raw)
  To: u-boot

On Thursday, October 09, 2014 at 01:58:24 AM, Alexey Ignatov wrote:
> mkimage -T mxs now support new flag in config file:
> DISPLAYPROGRESS - makes boot process print HTLLC characters for each
> BootROM instruction.
> 
> Signed-off-by: Alexey Ignatov <lexszero@gmail.com>

Hi!

[...]

> diff --git a/tools/mxsimage.h b/tools/mxsimage.h
> index 6cd59d2..9c61b4c 100644
> --- a/tools/mxsimage.h
> +++ b/tools/mxsimage.h
> @@ -81,8 +81,9 @@ struct sb_boot_image_header {
>  #define	SB_VERSION_MAJOR	1
>  #define	SB_VERSION_MINOR	1
> 
> -/* Enable to HTLLC verbose boot report. */
> -#define SB_IMAGE_FLAG_VERBOSE	(1 << 0)
> +/* Enable to HTLLC boot report. */
> +#define SB_IMAGE_FLAG_DISPLAY_PROGRESS	(1 << 0)
> +#define SB_IMAGE_FLAGS_MASK (SB_IMAGE_FLAG_DISPLAY_PROGRESS)

There's no need for the () around the value. Fix this in V3 and add:

Reviewed-by: Marek Vasut <marex@denx.de>

Also please CC Stefano (now on CC), so he can pick V3 of this.

Thank you!

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-10-09  0:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1412812704-4704-1-git-send-email-lexszero@gmail.com>
2014-10-09  0:08 ` [U-Boot] [PATCH v2] ARM: mxs: tools: Add support for boot progress display flag Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox