From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 9 Oct 2014 02:08:51 +0200 Subject: [U-Boot] [PATCH v2] ARM: mxs: tools: Add support for boot progress display flag In-Reply-To: <1412812704-4704-1-git-send-email-lexszero@gmail.com> References: <1412812704-4704-1-git-send-email-lexszero@gmail.com> Message-ID: <201410090208.51197.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday, October 09, 2014 at 01:58:24 AM, Alexey Ignatov wrote: > mkimage -T mxs now support new flag in config file: > DISPLAYPROGRESS - makes boot process print HTLLC characters for each > BootROM instruction. > > Signed-off-by: Alexey Ignatov Hi! [...] > diff --git a/tools/mxsimage.h b/tools/mxsimage.h > index 6cd59d2..9c61b4c 100644 > --- a/tools/mxsimage.h > +++ b/tools/mxsimage.h > @@ -81,8 +81,9 @@ struct sb_boot_image_header { > #define SB_VERSION_MAJOR 1 > #define SB_VERSION_MINOR 1 > > -/* Enable to HTLLC verbose boot report. */ > -#define SB_IMAGE_FLAG_VERBOSE (1 << 0) > +/* Enable to HTLLC boot report. */ > +#define SB_IMAGE_FLAG_DISPLAY_PROGRESS (1 << 0) > +#define SB_IMAGE_FLAGS_MASK (SB_IMAGE_FLAG_DISPLAY_PROGRESS) There's no need for the () around the value. Fix this in V3 and add: Reviewed-by: Marek Vasut Also please CC Stefano (now on CC), so he can pick V3 of this. Thank you! Best regards, Marek Vasut