From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 9 Oct 2014 17:12:03 +0200
Subject: [U-Boot] [PATCH fix for v2014.10 4/5] stdio: Add force
	parameter to stdio_deregister
In-Reply-To: <CAPnjgZ3bWb+FV7GPRvtEFUYHz9SyhhZSe97gx30V2fiZqBh1Zw@mail.gmail.com>
References: <1411224878-13692-1-git-send-email-hdegoede@redhat.com>
	<1411224878-13692-5-git-send-email-hdegoede@redhat.com>
	<CAPnjgZ3bWb+FV7GPRvtEFUYHz9SyhhZSe97gx30V2fiZqBh1Zw@mail.gmail.com>
Message-ID: <201410091712.03867.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thursday, October 09, 2014 at 08:18:14 AM, Simon Glass wrote:
> Hi,
> 
> On 20 September 2014 08:54, Hans de Goede <hdegoede@redhat.com> wrote:
> > In some cases we really want to move forward with a deregister, add a
> > force parameter to allow this, and replace the dev with a nulldev in
> > this case.
> > 
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>

[...]

> > diff --git a/drivers/serial/serial-uclass.c
> > b/drivers/serial/serial-uclass.c index d04104e..61cbdc6 100644
> > --- a/drivers/serial/serial-uclass.c
> > +++ b/drivers/serial/serial-uclass.c
> > @@ -197,7 +197,7 @@ static int serial_pre_remove(struct udevice *dev)
> > 
> >  #ifdef CONFIG_SYS_STDIO_DEREGISTER
> >  
> >         struct serial_dev_priv *upriv = dev->uclass_priv;
> > 
> > -       if (stdio_deregister_dev(upriv->sdev))
> > +       if (stdio_deregister_dev(upriv->sdev), 0)
> 
> That bracket seems to be in a strange place.

Good find, thanks! I have two questions:
1) How come I did not notice this and my build didn't spit?
2) Can either of you guys please prepare a patch?

Best regards,
Marek Vasut