From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH fix for v2014.10 4/5] stdio: Add force parameter to stdio_deregister
Date: Thu, 9 Oct 2014 19:32:13 +0200 [thread overview]
Message-ID: <201410091932.13484.marex@denx.de> (raw)
In-Reply-To: <CAPnjgZ0tFep0VqZ0FYMnF36G0Wx5XM+t91BUSoGdZMRvZoYvGQ@mail.gmail.com>
On Thursday, October 09, 2014 at 07:03:42 PM, Simon Glass wrote:
> Hi Marek,
>
> On 9 October 2014 10:27, Marek Vasut <marex@denx.de> wrote:
> > On Thursday, October 09, 2014 at 06:14:11 PM, Simon Glass wrote:
> >> Hi Marek,
> >>
> >> On 9 October 2014 09:12, Marek Vasut <marex@denx.de> wrote:
> >> > On Thursday, October 09, 2014 at 08:18:14 AM, Simon Glass wrote:
> >> > > Hi,
> >> > >
> >> > > On 20 September 2014 08:54, Hans de Goede <hdegoede@redhat.com> wrote:
> >> > > > In some cases we really want to move forward with a deregister,
> >> > > > add a force parameter to allow this, and replace the dev with a
> >> > > > nulldev in this case.
> >> > > >
> >> > > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >> >
> >> > [...]
> >> >
> >> > > > diff --git a/drivers/serial/serial-uclass.c
> >> > > > b/drivers/serial/serial-uclass.c index d04104e..61cbdc6 100644
> >> > > > --- a/drivers/serial/serial-uclass.c
> >> > > > +++ b/drivers/serial/serial-uclass.c
> >> > > > @@ -197,7 +197,7 @@ static int serial_pre_remove(struct udevice
> >> > > > *dev)
> >> > > >
> >> > > > #ifdef CONFIG_SYS_STDIO_DEREGISTER
> >> > > >
> >> > > > struct serial_dev_priv *upriv = dev->uclass_priv;
> >> > > >
> >> > > > - if (stdio_deregister_dev(upriv->sdev))
> >> > > > + if (stdio_deregister_dev(upriv->sdev), 0)
> >> > >
> >> > > That bracket seems to be in a strange place.
> >> >
> >> > Good find, thanks! I have two questions:
> >> > 1) How come I did not notice this and my build didn't spit?
> >>
> >> If you have CONFIG_SYS_STDIO_DEREGISTER, CONFIG_DM and
> >> CONFIG_DM_SERIAL set then I'm not sure. I made sure that sandbox has
> >> all of these but it might be the only board.
> >
> > I see, error on my end then. I will start building sandbox for the USB
> > tree. Thank you for pointing this out! This also stresses my point that
> > U-Boot project does need a proper CI (which we could have had thanks to
> > Vadim, but we didn't persudate that, dang again).
>
> What is a Cl? Do you mean his gerrit code review stuff?
I mean more continuous integration (build testing) of the code before a PR
is submitted to the ML. Right now, we all do our own thing when it comes to
testing before PR, but it would be nice to have one easy way of doing the
build testing before submitting the PR, don't you think ? This might apply
to Linux too.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-10-09 17:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 14:54 [U-Boot] [PATCH fix for v2014.10 0/5] USB keyboard: don't crash on "usb reset" Hans de Goede
2014-09-20 14:54 ` [U-Boot] [PATCH fix for v2014.10 1/5] usb: kbd: Do not treat -ENODEV as an error for usb_kbd_deregister Hans de Goede
2014-09-20 14:54 ` [U-Boot] [PATCH fix for v2014.10 2/5] usb: kbd: On a "usb reset" call usb_kbd_deregister() before calling usb_stop() Hans de Goede
2014-09-22 12:01 ` Marek Vasut
2014-09-23 9:10 ` Hans de Goede
2014-09-23 12:15 ` Marek Vasut
2014-09-23 12:51 ` Hans de Goede
2014-09-20 14:54 ` [U-Boot] [PATCH fix for v2014.10 3/5] usb: kbd: Remove check for already being registered Hans de Goede
2014-09-20 14:54 ` [U-Boot] [PATCH fix for v2014.10 4/5] stdio: Add force parameter to stdio_deregister Hans de Goede
2014-10-09 2:18 ` Rommel Custodio
2014-10-09 6:18 ` Simon Glass
2014-10-09 15:12 ` Marek Vasut
2014-10-09 16:14 ` Simon Glass
2014-10-09 16:27 ` Marek Vasut
2014-10-09 17:03 ` Simon Glass
2014-10-09 17:32 ` Marek Vasut [this message]
2014-10-09 18:04 ` Simon Glass
2014-10-09 23:59 ` Marek Vasut
2014-10-10 2:00 ` Simon Glass
2014-10-10 2:23 ` Marek Vasut
2014-10-10 2:26 ` Fabio Estevam
2014-10-10 2:35 ` Simon Glass
2014-10-10 10:42 ` Marek Vasut
2014-10-10 2:06 ` Fabio Estevam
2014-10-10 2:07 ` Simon Glass
2014-10-10 2:16 ` Fabio Estevam
2014-10-09 16:23 ` Tom Rini
2014-10-09 17:03 ` Simon Glass
2014-10-09 17:26 ` Tom Rini
2014-09-20 14:54 ` [U-Boot] [PATCH fix for v2014.10 5/5] usb: kbd: Allow "usb reset" to continue when an usb kbd is used Hans de Goede
2014-09-21 10:26 ` [U-Boot] [PATCH fix for v2014.10 0/5] USB keyboard: don't crash on "usb reset" Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201410091932.13484.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox