From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] PATI: fix broken SPI access
Date: Fri, 10 Oct 2014 12:14:14 -0400 [thread overview]
Message-ID: <20141010161414.GU25506@bill-the-cat> (raw)
In-Reply-To: <20140930144811.GY25506@bill-the-cat>
On Tue, Sep 30, 2014 at 10:48:11AM -0400, Tom Rini wrote:
> On Tue, Sep 30, 2014 at 08:06:43PM +0530, Jagan Teki wrote:
> > On 30 September 2014 18:41, David M?ller (ELSOFT AG)
> > <d.mueller@elsoft.ch> wrote:
> > > Jagan Teki wrote:
> > >> On 30 September 2014 16:53, David M?ller <d.mueller@elsoft.ch> wrote:
> > >>> +int board_early_init_f(void)
> > >>> +{
> > >>> + spi_init_f();
> > >>
> > >> Why you need to do this, spi_init_f is trying to call from
> > >> arch/powerpc/lib/board.c
> > >> any specific reason, I couldn't understand the fix you mentioned on
> > >> the commit body.
> > >
> > > There is an EEPROM attached to the SPI channel containing vital board
> > > data. Calling spi_init_f() from arch/powerpc/lib/board.c will be too late.
> >
> > Sorry, this looks an other issue - but anyway we're trying to remove
> > spi_init* stuff
> > from drivers/spi/* in future and I don't think it's a good idea to use that.
>
> It's also not a good idea to say that we'll leave a board broken until
> something better comes along. There should be a comment added to the
> code here making it clear _why_ we need this done early.
And again, for the record, I wanted to _fix_ things today so we can
clean them up tomorrow, rather than keep something broken so we can fix
it later.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141010/cb2a5b66/attachment.pgp>
next prev parent reply other threads:[~2014-10-10 16:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 11:23 [U-Boot] [PATCH] PATI: fix broken SPI access David Müller
2014-09-30 12:27 ` Jagan Teki
2014-09-30 13:11 ` David Müller (ELSOFT AG)
2014-09-30 14:36 ` Jagan Teki
2014-09-30 14:48 ` Tom Rini
2014-10-10 16:14 ` Tom Rini [this message]
2014-10-10 16:22 ` Jagan Teki
2014-09-30 14:58 ` David Müller (ELSOFT AG)
2014-09-30 16:08 ` Jagan Teki
2014-10-10 14:41 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010161414.GU25506@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox