[U-Boot] [PATCH V7] ARM: mx6: Add support for Kosagi Novena

Fabio Estevam
2014-10-11T01:39:36Z

Hi Marek,

On Fri, Oct 10, 2014 at 10:14 PM, Marek Vasut <marex@denx.de> wrote:

> +int board_early_init_f(void)
> +{
> +#if defined(CONFIG_VIDEO_IPUV3)
> + setup_display();
> +#endif
> +
> + /* Bring Ethernet PHY out of reset. */
> + gpio_set_value(IMX_GPIO_NR(3, 23), 1);

No delay needed here prior to setting it to 1?

> +/* System configurations */
> +#define CONFIG_MX6
> +#define CONFIG_SYS_MX6_HCLK 24000000
> +#define CONFIG_SYS_MX6_CLK32 32768

These are the default values from
arch/arm/include/asm/arch-mx6/clock.h. You could just drop them.

> +/* Extra U-Boot environment. */
> +#define CONFIG_EXTRA_ENV_SETTINGS \
> + "fdt_high=0xffffffff\0" \
> + "initrd_high=0xffffffff\0" \
> + "consdev=ttymxc1\0" \
> + "baudrate=115200\0" \
> + "bootdev=/dev/mmcblk0p1\0" \
> + "rootdev=/dev/mmcblk0p2\0" \
> + "netdev=eth0\0" \
> + "rootpath=/opt/eldk-5.5/armv7a-hf/rootfs-qte-sdk\0" \

Hardcoded root path again? I thought we already discussed this in
previous versions of this patch.