public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Siarhei Siamashka <siarhei.siamashka@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Add CONFIG_MACH_TYPE defines to sun4i, sun5i and sun7i
Date: Wed, 15 Oct 2014 13:48:43 +0300	[thread overview]
Message-ID: <20141015134843.32f9b299@i7> (raw)
In-Reply-To: <1413204935-9157-1-git-send-email-hdegoede@redhat.com>

On Mon, 13 Oct 2014 14:55:35 +0200
Hans de Goede <hdegoede@redhat.com> wrote:

> Many people are still using old linux-sunxi-3.4 kernels on sunxi devices,
> adding the proper MACH_TYPE defines for this allows people to switch to
> upstream u-boot, so that we can stop maintaining the linux-sunxi u-boot fork.
> 
> These machine-ids are all properly registered at:
> 
> http://www.arm.linux.org.uk/developer/machines/
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  include/configs/sun4i.h | 1 +
>  include/configs/sun5i.h | 1 +
>  include/configs/sun7i.h | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/include/configs/sun4i.h b/include/configs/sun4i.h
> index 5611ecc..d0191a3 100644
> --- a/include/configs/sun4i.h
> +++ b/include/configs/sun4i.h
> @@ -15,6 +15,7 @@
>  #define CONFIG_CLK_FULL_SPEED		1008000000
>  
>  #define CONFIG_SYS_PROMPT		"sun4i# "
> +#define CONFIG_MACH_TYPE		4104
>  
>  #ifdef CONFIG_USB_EHCI
>  #define CONFIG_USB_EHCI_SUNXI
> diff --git a/include/configs/sun5i.h b/include/configs/sun5i.h
> index 6066371..7b683e9 100644
> --- a/include/configs/sun5i.h
> +++ b/include/configs/sun5i.h
> @@ -15,6 +15,7 @@
>  #define CONFIG_CLK_FULL_SPEED		1008000000
>  
>  #define CONFIG_SYS_PROMPT		"sun5i# "
> +#define CONFIG_MACH_TYPE		4138
>  
>  #ifdef CONFIG_USB_EHCI
>  #define CONFIG_USB_EHCI_SUNXI
> diff --git a/include/configs/sun7i.h b/include/configs/sun7i.h
> index a902b84..966cbd8 100644
> --- a/include/configs/sun7i.h
> +++ b/include/configs/sun7i.h
> @@ -16,6 +16,7 @@
>  #define CONFIG_CLK_FULL_SPEED		912000000
>  
>  #define CONFIG_SYS_PROMPT		"sun7i# "
> +#define CONFIG_MACH_TYPE		4283
>  
>  #ifdef CONFIG_USB_EHCI
>  #define CONFIG_USB_EHCI_SUNXI

This patch is just trying to remove the safety guards (which exist
there for a reason!) without addressing the real compatibility
issues. This is a very bad idea in my opinion. We can do a better
job.

-- 
Best regards,
Siarhei Siamashka

  parent reply	other threads:[~2014-10-15 10:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-13 12:55 [U-Boot] [PATCH] sunxi: Add CONFIG_MACH_TYPE defines to sun4i, sun5i and sun7i Hans de Goede
2014-10-14  9:56 ` Ian Campbell
2014-10-15 10:48 ` Siarhei Siamashka [this message]
2014-10-16  8:50   ` Hans de Goede
2014-10-16  9:06     ` Jeroen Hofstee
2014-10-16 18:31     ` Siarhei Siamashka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141015134843.32f9b299@i7 \
    --to=siarhei.siamashka@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox