From mboxrd@z Thu Jan  1 00:00:00 1970
From: Siarhei Siamashka <siarhei.siamashka@gmail.com>
Date: Wed, 15 Oct 2014 13:48:43 +0300
Subject: [U-Boot] [PATCH] sunxi: Add CONFIG_MACH_TYPE defines to sun4i,
 sun5i and sun7i
In-Reply-To: <1413204935-9157-1-git-send-email-hdegoede@redhat.com>
References: <1413204935-9157-1-git-send-email-hdegoede@redhat.com>
Message-ID: <20141015134843.32f9b299@i7>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, 13 Oct 2014 14:55:35 +0200
Hans de Goede <hdegoede@redhat.com> wrote:

> Many people are still using old linux-sunxi-3.4 kernels on sunxi devices,
> adding the proper MACH_TYPE defines for this allows people to switch to
> upstream u-boot, so that we can stop maintaining the linux-sunxi u-boot fork.
> 
> These machine-ids are all properly registered at:
> 
> http://www.arm.linux.org.uk/developer/machines/
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  include/configs/sun4i.h | 1 +
>  include/configs/sun5i.h | 1 +
>  include/configs/sun7i.h | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/include/configs/sun4i.h b/include/configs/sun4i.h
> index 5611ecc..d0191a3 100644
> --- a/include/configs/sun4i.h
> +++ b/include/configs/sun4i.h
> @@ -15,6 +15,7 @@
>  #define CONFIG_CLK_FULL_SPEED		1008000000
>  
>  #define CONFIG_SYS_PROMPT		"sun4i# "
> +#define CONFIG_MACH_TYPE		4104
>  
>  #ifdef CONFIG_USB_EHCI
>  #define CONFIG_USB_EHCI_SUNXI
> diff --git a/include/configs/sun5i.h b/include/configs/sun5i.h
> index 6066371..7b683e9 100644
> --- a/include/configs/sun5i.h
> +++ b/include/configs/sun5i.h
> @@ -15,6 +15,7 @@
>  #define CONFIG_CLK_FULL_SPEED		1008000000
>  
>  #define CONFIG_SYS_PROMPT		"sun5i# "
> +#define CONFIG_MACH_TYPE		4138
>  
>  #ifdef CONFIG_USB_EHCI
>  #define CONFIG_USB_EHCI_SUNXI
> diff --git a/include/configs/sun7i.h b/include/configs/sun7i.h
> index a902b84..966cbd8 100644
> --- a/include/configs/sun7i.h
> +++ b/include/configs/sun7i.h
> @@ -16,6 +16,7 @@
>  #define CONFIG_CLK_FULL_SPEED		912000000
>  
>  #define CONFIG_SYS_PROMPT		"sun7i# "
> +#define CONFIG_MACH_TYPE		4283
>  
>  #ifdef CONFIG_USB_EHCI
>  #define CONFIG_USB_EHCI_SUNXI

This patch is just trying to remove the safety guards (which exist
there for a reason!) without addressing the real compatibility
issues. This is a very bad idea in my opinion. We can do a better
job.

-- 
Best regards,
Siarhei Siamashka