From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-boot] [Patch v4 2/6] keystone2: clock: add K2L clock definitions and commands
Date: Mon, 20 Oct 2014 11:55:10 -0400 [thread overview]
Message-ID: <20141020155510.GP25506@bill-the-cat> (raw)
In-Reply-To: <54452D29.2020709@ti.com>
On Mon, Oct 20, 2014 at 06:41:29PM +0300, Ivan Khoronzhuk wrote:
> On 10/20/2014 06:13 PM, Tom Rini wrote:
> >On Wed, Oct 15, 2014 at 02:55:28AM +0300, Ivan Khoronzhuk wrote:
> >
> >>From: Hao Zhang <hzhang@ti.com>
> >>
> >>This patch adds clock definitions and commands to support Keystone II
> >>K2L SOC.
> >>
> >>Acked-by: Vitaly Andrianov <vitalya@ti.com>
> >>Signed-off-by: Hao Zhang <hzhang@ti.com>
> >>Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> >[snip]
> >>diff --git a/arch/arm/cpu/armv7/keystone/cmd_clock.c b/arch/arm/cpu/armv7/keystone/cmd_clock.c
> >>index d97c95b..9204887 100644
> >>--- a/arch/arm/cpu/armv7/keystone/cmd_clock.c
> >>+++ b/arch/arm/cpu/armv7/keystone/cmd_clock.c
> >>@@ -72,6 +72,13 @@ U_BOOT_CMD(
> >> "<pa|ddr3> <mult> <div> <OD>\n"
> >> );
> >> #endif
> >>+#ifdef CONFIG_SOC_K2L
> >>+U_BOOT_CMD(
> >>+ pllset, 5, 0, do_pll_cmd,
> >>+ "set pll multiplier and pre divider",
> >>+ "<pa|arm|ddr3> <mult> <div> <OD>\n"
> >>+);
> >>+#endif
> >> int do_getclk_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> >> {
> >>@@ -101,6 +108,9 @@ U_BOOT_CMD(
> >> #ifdef CONFIG_SOC_K2E
> >> "See the 'enum clk_e' in the clock-k2e.h for clk indexes\n"
> >> #endif
> >>+#ifdef CONFIG_SOC_K2L
> >>+ "See the 'enum clk_e' in the clock-k2l.h for clk indexes\n"
> >>+#endif
> >> );
> >I'm not going to block on all of this duplication, but we need to think
> >how to do this cleaner so that the next K2 variant doesn't expand this
> >mess further. Thanks!
> >
>
> I'll correct it to one line:
> "See the 'enum clk_e' in the clock-k2*.h for clk indexes\n"
That helps the second hunk, but still leaves the first. At some point,
even, we shouldn't say "go modify file foo" in the binary, that belongs
in board documentation. Like I said, this needs a little bit of
thinking.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141020/5863a505/attachment.pgp>
next prev parent reply other threads:[~2014-10-20 15:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 23:55 [U-Boot] [U-boot] [Patch v4 0/6] keystone2: add k2l SoC and k2l_evm board support Ivan Khoronzhuk
2014-10-14 23:55 ` [U-Boot] [U-boot] [Patch v4 1/6] ARM: keystone2: add K2L device hardware definitions Ivan Khoronzhuk
2014-10-14 23:55 ` [U-Boot] [U-boot] [Patch v4 2/6] keystone2: clock: add K2L clock definitions and commands Ivan Khoronzhuk
2014-10-20 15:13 ` Tom Rini
2014-10-20 15:41 ` Ivan Khoronzhuk
2014-10-20 15:55 ` Tom Rini [this message]
2014-10-22 13:51 ` Ivan Khoronzhuk
2014-10-14 23:55 ` [U-Boot] [U-boot] [Patch v4 3/6] keystone2: msmc: add MSMC cache coherency support for K2L SOC Ivan Khoronzhuk
2014-10-20 15:13 ` Tom Rini
2014-10-20 15:20 ` Ivan Khoronzhuk
2014-10-14 23:55 ` [U-Boot] [U-boot] [Patch v4 4/6] ARM: keystone2: spl: add K2L SoC support Ivan Khoronzhuk
2014-10-14 23:55 ` [U-Boot] [U-boot] [Patch v4 5/6] keystone2: enable OSR clock domain for K2L SoC Ivan Khoronzhuk
2014-10-14 23:55 ` [U-Boot] [U-boot] [Patch v4 6/6] keystone2: k2l-evm: add board support Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020155510.GP25506@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox