From: Andrew Ruder <andy@aeruder.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions
Date: Mon, 20 Oct 2014 14:39:41 -0500 [thread overview]
Message-ID: <20141020193940.GB10047@og3k> (raw)
In-Reply-To: <20141020191713.GR25506@bill-the-cat>
On Mon, Oct 20, 2014 at 03:17:13PM -0400, Tom Rini wrote:
> You shouldn't have to add this to avoid a warning I think. And frankly,
> if it does for some reason since 3/3 makes use of dev, I'm OK with a
> bisect adding a trivial warning like this, rather than do compiler
> games.
Fair enough, the more I look at it, the more it looks like I probably
missed a warning on this patch + CONFIG_DM9000_NO_SROM (defined but not
used) so it is still pretty easy to trigger a warning on this patch.
I'll just remove the indicated parts in v2 of the series and let the
warnings get cleaned up in 3/3 as you have suggested.
Will send a v2 of series in a bit after seeing if there is any feedback
on the approaches used in 3/3.
- Andy
next prev parent reply other threads:[~2014-10-20 19:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 14:59 [U-Boot] [PATCH 0/3] DM9000 support for multiple interfaces Andrew Ruder
2014-10-20 14:59 ` [U-Boot] [PATCH 1/3] dm9000: mark dump_regs() function as unused Andrew Ruder
2014-10-20 19:10 ` Tom Rini
2014-10-20 14:59 ` [U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions Andrew Ruder
2014-10-20 15:22 ` Stefano Babic
2014-10-20 19:17 ` Tom Rini
2014-10-20 19:39 ` Andrew Ruder [this message]
2014-10-20 14:59 ` [U-Boot] [PATCH 3/3] dm9000: rework dm9000 to support multiple devices Andrew Ruder
2014-10-20 15:45 ` Andrew Ruder
2014-10-20 18:11 ` [U-Boot] [PATCH 3/3 V2] " Andrew Ruder
2014-10-20 20:00 ` Tom Rini
2014-10-20 20:16 ` Andrew Ruder
2014-10-20 23:47 ` Tom Rini
2015-08-11 17:58 ` Joe Hershberger
2015-08-11 21:10 ` Andrew Ruder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020193940.GB10047@og3k \
--to=andy@aeruder.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox