public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3 V2] dm9000: rework dm9000 to support multiple devices
Date: Mon, 20 Oct 2014 16:00:16 -0400	[thread overview]
Message-ID: <20141020200016.GS25506@bill-the-cat> (raw)
In-Reply-To: <1413828708-24729-1-git-send-email-andrew.ruder@elecsyscorp.com>

On Mon, Oct 20, 2014 at 01:11:48PM -0500, Andrew Ruder wrote:
> The DM9000 was hard-coded to only support one DM9000 device.  This patch
> adds a new initialization function - dm9000_initialize_ex() - to support
> registering multiple (and possibly dynamic) numbers of dm9000 devices.
> This patch consists of:
> 
>    * Change the board_info struct to a private struct under eth_device.
>    * Add io address/data address/srom availability information to this
>      private struct.
>    * Replace all uses of DM9000_IO/DM9000_DATA with new members, ensure
>      that the eth_device struct propagates down to all helper functions.
>    * Make dm9000_initialize() call dm9000_initialize_ex() with filled
>      in information from the old preprocessor symbols (DM9000_IO,
>      DM9000_DATA, etc.)

So, on new platforms we call dm9000_initialize with the right IO/DATA
locations for the given device, yes?  I think I'd rather update everyone
else to call things the right and new way, rather than work-around
supporting both.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141020/c99d859f/attachment.pgp>

  reply	other threads:[~2014-10-20 20:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 14:59 [U-Boot] [PATCH 0/3] DM9000 support for multiple interfaces Andrew Ruder
2014-10-20 14:59 ` [U-Boot] [PATCH 1/3] dm9000: mark dump_regs() function as unused Andrew Ruder
2014-10-20 19:10   ` Tom Rini
2014-10-20 14:59 ` [U-Boot] [PATCH 2/3] dm9000: Add struct eth_device * to SROM functions Andrew Ruder
2014-10-20 15:22   ` Stefano Babic
2014-10-20 19:17   ` Tom Rini
2014-10-20 19:39     ` Andrew Ruder
2014-10-20 14:59 ` [U-Boot] [PATCH 3/3] dm9000: rework dm9000 to support multiple devices Andrew Ruder
2014-10-20 15:45   ` Andrew Ruder
2014-10-20 18:11 ` [U-Boot] [PATCH 3/3 V2] " Andrew Ruder
2014-10-20 20:00   ` Tom Rini [this message]
2014-10-20 20:16     ` Andrew Ruder
2014-10-20 23:47       ` Tom Rini
2015-08-11 17:58         ` Joe Hershberger
2015-08-11 21:10           ` Andrew Ruder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141020200016.GS25506@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox