* [U-Boot] [PATCH] ot1200: fix sf detection
2014-10-22 9:29 [U-Boot] [PATCH] ot1200: fix sf detection Christian Gmeiner
@ 2014-10-22 9:35 ` Stefano Babic
2014-10-22 10:09 ` Anatolij Gustschin
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2014-10-22 9:35 UTC (permalink / raw)
To: u-boot
On 22/10/2014 11:29, Christian Gmeiner wrote:
> Commit 155fa9af95ac5be857a7327e7a968a296e60d4c8 changed the way
> to define a GPIO line, which can be used to force CS high
> across multiple transactions. In order to fix sf detection
> change board code to make use of board_spi_cs_gpio(..).
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
> board/bachmann/ot1200/ot1200.c | 5 +++++
> include/configs/ot1200.h | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/board/bachmann/ot1200/ot1200.c b/board/bachmann/ot1200/ot1200.c
> index 0d5ede5..2962e0c 100644
> --- a/board/bachmann/ot1200/ot1200.c
> +++ b/board/bachmann/ot1200/ot1200.c
> @@ -98,6 +98,11 @@ static void setup_iomux_spi(void)
> imx_iomux_v3_setup_multiple_pads(ecspi1_pads, ARRAY_SIZE(ecspi1_pads));
> }
>
> +int board_spi_cs_gpio(unsigned bus, unsigned cs)
> +{
> + return (bus == 2 && cs == 0) ? (IMX_GPIO_NR(1, 3)) : -1;
> +}
> +
> int board_early_init_f(void)
> {
> setup_iomux_uart();
> diff --git a/include/configs/ot1200.h b/include/configs/ot1200.h
> index 071880f..d7696bd 100644
> --- a/include/configs/ot1200.h
> +++ b/include/configs/ot1200.h
> @@ -47,7 +47,7 @@
> #define CONFIG_SPI_FLASH_SST
> #define CONFIG_MXC_SPI
> #define CONFIG_SF_DEFAULT_BUS 2
> -#define CONFIG_SF_DEFAULT_CS (0|(IMX_GPIO_NR(1, 3)<<8))
> +#define CONFIG_SF_DEFAULT_CS 0
> #define CONFIG_SF_DEFAULT_SPEED 25000000
> #define CONFIG_SF_DEFAULT_MODE (SPI_MODE_0)
>
>
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] ot1200: fix sf detection
2014-10-22 9:29 [U-Boot] [PATCH] ot1200: fix sf detection Christian Gmeiner
2014-10-22 9:35 ` Stefano Babic
@ 2014-10-22 10:09 ` Anatolij Gustschin
2014-11-05 14:57 ` Heiko Schocher
2014-10-22 13:18 ` Nikita Kiryanov
2014-10-23 8:03 ` Stefano Babic
3 siblings, 1 reply; 6+ messages in thread
From: Anatolij Gustschin @ 2014-10-22 10:09 UTC (permalink / raw)
To: u-boot
Hi all,
On Wed, 22 Oct 2014 11:29:51 +0200
Christian Gmeiner <christian.gmeiner@gmail.com> wrote:
> Commit 155fa9af95ac5be857a7327e7a968a296e60d4c8 changed the way
> to define a GPIO line, which can be used to force CS high
> across multiple transactions. In order to fix sf detection
> change board code to make use of board_spi_cs_gpio(..).
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
> board/bachmann/ot1200/ot1200.c | 5 +++++
> include/configs/ot1200.h | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
There are another two board that might be affected:
$ grep --exclude=ot1200.h -r SF_DEFAULT_CS include/configs/ | grep IMX_GPIO_NR
include/configs/aristainetos.h:#define CONFIG_SF_DEFAULT_CS (0|(IMX_GPIO_NR(3, 20)<<8))
include/configs/tqma6.h:#define CONFIG_SF_DEFAULT_CS (0 | (IMX_GPIO_NR(3, 19) << 8))
So, I'm CC'ing board maintainers, please test/fix them too. Thanks!
Anatolij
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ot1200: fix sf detection
2014-10-22 10:09 ` Anatolij Gustschin
@ 2014-11-05 14:57 ` Heiko Schocher
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Schocher @ 2014-11-05 14:57 UTC (permalink / raw)
To: u-boot
Hello Anatolij,
Am 22.10.2014 12:09, schrieb Anatolij Gustschin:
> Hi all,
>
> On Wed, 22 Oct 2014 11:29:51 +0200
> Christian Gmeiner<christian.gmeiner@gmail.com> wrote:
>
>> Commit 155fa9af95ac5be857a7327e7a968a296e60d4c8 changed the way
>> to define a GPIO line, which can be used to force CS high
>> across multiple transactions. In order to fix sf detection
>> change board code to make use of board_spi_cs_gpio(..).
>>
>> Signed-off-by: Christian Gmeiner<christian.gmeiner@gmail.com>
>> ---
>> board/bachmann/ot1200/ot1200.c | 5 +++++
>> include/configs/ot1200.h | 2 +-
>> 2 files changed, 6 insertions(+), 1 deletion(-)
>
>
> There are another two board that might be affected:
>
> $ grep --exclude=ot1200.h -r SF_DEFAULT_CS include/configs/ | grep IMX_GPIO_NR
> include/configs/aristainetos.h:#define CONFIG_SF_DEFAULT_CS (0|(IMX_GPIO_NR(3, 20)<<8))
> include/configs/tqma6.h:#define CONFIG_SF_DEFAULT_CS (0 | (IMX_GPIO_NR(3, 19)<< 8))
>
> So, I'm CC'ing board maintainers, please test/fix them too. Thanks!
thanks for adding me to cc !
I fix this issue here:
http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commit;h=2f6bb0a9419ec8016524142cb54fef81038b346e
already applied in the u-boot.imx tree ...
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ot1200: fix sf detection
2014-10-22 9:29 [U-Boot] [PATCH] ot1200: fix sf detection Christian Gmeiner
2014-10-22 9:35 ` Stefano Babic
2014-10-22 10:09 ` Anatolij Gustschin
@ 2014-10-22 13:18 ` Nikita Kiryanov
2014-10-23 8:03 ` Stefano Babic
3 siblings, 0 replies; 6+ messages in thread
From: Nikita Kiryanov @ 2014-10-22 13:18 UTC (permalink / raw)
To: u-boot
On 22/10/14 12:29, Christian Gmeiner wrote:
> Commit 155fa9af95ac5be857a7327e7a968a296e60d4c8 changed the way
> to define a GPIO line, which can be used to force CS high
> across multiple transactions. In order to fix sf detection
> change board code to make use of board_spi_cs_gpio(..).
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
> board/bachmann/ot1200/ot1200.c | 5 +++++
> include/configs/ot1200.h | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/board/bachmann/ot1200/ot1200.c b/board/bachmann/ot1200/ot1200.c
> index 0d5ede5..2962e0c 100644
> --- a/board/bachmann/ot1200/ot1200.c
> +++ b/board/bachmann/ot1200/ot1200.c
> @@ -98,6 +98,11 @@ static void setup_iomux_spi(void)
> imx_iomux_v3_setup_multiple_pads(ecspi1_pads, ARRAY_SIZE(ecspi1_pads));
> }
>
> +int board_spi_cs_gpio(unsigned bus, unsigned cs)
> +{
> + return (bus == 2 && cs == 0) ? (IMX_GPIO_NR(1, 3)) : -1;
> +}
> +
> int board_early_init_f(void)
> {
> setup_iomux_uart();
> diff --git a/include/configs/ot1200.h b/include/configs/ot1200.h
> index 071880f..d7696bd 100644
> --- a/include/configs/ot1200.h
> +++ b/include/configs/ot1200.h
> @@ -47,7 +47,7 @@
> #define CONFIG_SPI_FLASH_SST
> #define CONFIG_MXC_SPI
> #define CONFIG_SF_DEFAULT_BUS 2
> -#define CONFIG_SF_DEFAULT_CS (0|(IMX_GPIO_NR(1, 3)<<8))
> +#define CONFIG_SF_DEFAULT_CS 0
> #define CONFIG_SF_DEFAULT_SPEED 25000000
> #define CONFIG_SF_DEFAULT_MODE (SPI_MODE_0)
>
>
Acked-by: Nikita Kiryanov <nikita@compulab.co.il>
--
Regards,
Nikita Kiryanov
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] ot1200: fix sf detection
2014-10-22 9:29 [U-Boot] [PATCH] ot1200: fix sf detection Christian Gmeiner
` (2 preceding siblings ...)
2014-10-22 13:18 ` Nikita Kiryanov
@ 2014-10-23 8:03 ` Stefano Babic
3 siblings, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2014-10-23 8:03 UTC (permalink / raw)
To: u-boot
Hi Christian,
On 22/10/2014 11:29, Christian Gmeiner wrote:
> Commit 155fa9af95ac5be857a7327e7a968a296e60d4c8 changed the way
> to define a GPIO line, which can be used to force CS high
> across multiple transactions. In order to fix sf detection
> change board code to make use of board_spi_cs_gpio(..).
>
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread