public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] Add deep sleep framework support for Freescale QorIQ platforms
Date: Wed, 22 Oct 2014 09:53:48 -0400	[thread overview]
Message-ID: <20141022135348.GD25506@bill-the-cat> (raw)
In-Reply-To: <1411894788-41758-2-git-send-email-Yuantian.Tang@freescale.com>

On Sun, Sep 28, 2014 at 04:59:45PM +0800, Yuantian.Tang at freescale.com wrote:
> From: Tang Yuantian <Yuantian.Tang@freescale.com>
> 
> When Freescale QorIQ SoCs wake up from deep sleep, control is
> passed to the primary core that starts executing uboot. After
> re-initialized some IP blocks, like DDRC, kernel will take
> responsibility to continue to restore environment it leaves before.
> 
> This patch adds the deep sleep framework support for all Freescale
> QorIQ platforms that use generic_board configuation.
> 
> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> ---
>  common/board_f.c               | 10 +++++++++
>  drivers/ddr/fsl/arm_ddr_gen3.c | 48 +++++++++++++++++++++++++++++++++++++-----
>  include/fsl_ddr_sdram.h        |  2 ++
>  include/fsl_sleep.h            | 32 ++++++++++++++++++++++++++++
>  4 files changed, 87 insertions(+), 5 deletions(-)
>  create mode 100644 include/fsl_sleep.h
> 
> diff --git a/common/board_f.c b/common/board_f.c
> index e6aa298..b736d29 100644
> --- a/common/board_f.c
> +++ b/common/board_f.c
> @@ -56,6 +56,9 @@
>  #endif
>  #include <dm/root.h>
>  #include <linux/compiler.h>
> +#ifdef CONFIG_FSL_DEEP_SLEEP
> +#include <fsl_sleep.h>
> +#endif
>  
>  /*
>   * Pointer to initial global data area
> @@ -921,6 +924,9 @@ static init_fnc_t init_sequence_f[] = {
>  #if defined(CONFIG_MIPS) || defined(CONFIG_PPC)
>  	init_func_ram,
>  #endif
> +#ifdef CONFIG_FSL_DEEP_SLEEP
> +	fsl_dp_resume,
> +#endif

Is there not an existing hook you can use here instead?  Is misc_init_f
too early?  If we're going to add a new hook in here, it needs to be
somewhat generically named, with the requirements of the system spelled
out.  Some TI parts have a (setting aside marketing-speak) similar
function and I believe the U-Boot patches for that use an existing hook
to notice what happened and do what's needed.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141022/265daa03/attachment.pgp>

  reply	other threads:[~2014-10-22 13:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-28  8:59 [U-Boot] [PATCH 0/4] Deep sleep patches for Freescale QorIQ platforms Yuantian.Tang at freescale.com
2014-09-28  8:59 ` [U-Boot] [PATCH 1/4] Add deep sleep framework support " Yuantian.Tang at freescale.com
2014-10-22 13:53   ` Tom Rini [this message]
2014-10-23  2:53     ` Yuantian Tang
2014-10-23  3:06       ` York Sun
2014-10-23  3:26         ` Yuantian Tang
2014-10-23  3:33           ` York Sun
2014-10-23  4:15           ` York Sun
2014-10-23  4:47             ` Yuantian Tang
2014-10-23 18:58               ` Tom Rini
2014-09-28  8:59 ` [U-Boot] [PATCH 2/4] ARM: HYP/non-sec: Make armv7_init_nonsec() usable before relocation Yuantian.Tang at freescale.com
2014-09-28  8:59 ` [U-Boot] [PATCH 3/4] arm: ls102xa: Fixed a register definition error Yuantian.Tang at freescale.com
2014-09-28  8:59 ` [U-Boot] [PATCH 4/4] arm: ls1021qds: Add deep sleep support Yuantian.Tang at freescale.com
  -- strict thread matches above, loose matches on Subject: below --
2014-10-09  8:11 [U-Boot] [PATCH 0/4] Deep sleep patches for Freescale QorIQ platforms Yuantian.Tang at freescale.com
2014-10-09  8:11 ` [U-Boot] [PATCH 1/4] Add deep sleep framework support " Yuantian.Tang at freescale.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141022135348.GD25506@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox