From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 04/13] dm: spl: Make simple malloc() available when enabled
Date: Fri, 24 Oct 2014 14:59:05 -0400 [thread overview]
Message-ID: <20141024185905.GJ25506@bill-the-cat> (raw)
In-Reply-To: <1414091770-26319-5-git-send-email-sjg@chromium.org>
On Thu, Oct 23, 2014 at 01:16:01PM -0600, Simon Glass wrote:
> Set up the simple malloc() implementation when requested, in preference to
> the full malloc().
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2: None
>
> common/spl/spl.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index b16664f..7168854 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -134,9 +134,13 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
> u32 boot_device;
> debug(">>spl:board_init_r()\n");
>
> -#ifdef CONFIG_SYS_SPL_MALLOC_START
> +#if defined(CONFIG_SYS_SPL_MALLOC_START)
> mem_malloc_init(CONFIG_SYS_SPL_MALLOC_START,
> CONFIG_SYS_SPL_MALLOC_SIZE);
> + gd->flags |= GD_FLG_FULL_MALLOC_INIT;
> +#elif defined(CONFIG_SYS_MALLOC_F_LEN)
> + gd->malloc_limit = gd->malloc_base + CONFIG_SYS_MALLOC_F_LEN;
> + gd->malloc_ptr = 0;
> #endif
>
> #ifndef CONFIG_PPC
> @@ -233,6 +237,11 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
> default:
> debug("Unsupported OS image.. Jumping nevertheless..\n");
> }
> +#if defined(CONFIG_SYS_MALLOC_F_LEN) && !defined(CONFIG_SYS_SPL_MALLOC_SIZE)
> + debug("SPL malloc() used %#lx bytes (%ld KB)\n", gd->malloc_ptr,
> + gd->malloc_ptr / 1024);
> +#endif
> +
> jump_to_image_no_args(&spl_image);
> }
I don't know if this is right. Take the example of am335x + booting
from a FAT fs image. We'll need early malloc prior to DDR being
available, so the tiny space (1-2kb). But once DDR is up we need a more
complete malloc so that we can use FAT. I don't have the size handy but
I'm going to guess that (a) it's bigger than 1-2kb (b) bigger than we
can squeeze into SRAM.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141024/79a92841/attachment.pgp>
next prev parent reply other threads:[~2014-10-24 18:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 19:15 [U-Boot] [PATCH v2 0/13] dm: Implement driver model support in SPL Simon Glass
2014-10-23 19:15 ` [U-Boot] [PATCH v2 01/13] dm: dts: Move omap device tree includes to correct place Simon Glass
2014-10-24 19:05 ` Tom Rini
2014-10-23 19:15 ` [U-Boot] [PATCH v2 02/13] dm: Split the simple malloc() implementation into its own file Simon Glass
2014-10-24 19:05 ` Tom Rini
2014-10-23 19:16 ` [U-Boot] [PATCH v2 03/13] dm: arm: spl: Allow simple malloc() in SPL Simon Glass
2014-10-23 19:16 ` [U-Boot] [PATCH v2 04/13] dm: spl: Make simple malloc() available when enabled Simon Glass
2014-10-24 18:59 ` Tom Rini [this message]
2014-10-28 0:07 ` Simon Glass
2014-10-23 19:16 ` [U-Boot] [PATCH v2 05/13] dm: spl: Allow driver model to be used Simon Glass
2014-10-24 19:06 ` Tom Rini
2014-10-23 19:16 ` [U-Boot] [PATCH v2 06/13] dm: Allow device removal features to be dropped Simon Glass
2014-10-23 19:16 ` [U-Boot] [PATCH v2 07/13] dm: Allow stdio registration " Simon Glass
2014-10-24 19:06 ` Tom Rini
2014-10-23 19:16 ` [U-Boot] [PATCH v2 08/13] dm: Disable dm_warn() in SPL Simon Glass
2014-10-24 19:07 ` Tom Rini
2014-10-23 19:16 ` [U-Boot] [PATCH v2 09/13] dm: tegra: Add platform data for the SPL uart Simon Glass
2014-10-23 19:16 ` [U-Boot] [PATCH v2 10/13] dm: tegra: Add platform data for the GPIO driver Simon Glass
2014-10-23 19:16 ` [U-Boot] [PATCH v2 11/13] dm: arm: spl: Make driver model linker lists available Simon Glass
2014-10-24 19:08 ` Tom Rini
2014-10-23 19:16 ` [U-Boot] [PATCH v2 12/13] dm: tegra: Enable driver model in SPL and adjust the GPIO driver Simon Glass
2014-10-23 19:16 ` [U-Boot] [PATCH v2 13/13] dm: Update documentation to include CONFIG_DM... options Simon Glass
2014-10-23 20:17 ` Masahiro YAMADA
2014-10-24 1:05 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024185905.GJ25506@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox