[U-Boot] [PATCH] arm: socfpga: config: Add USB support example

[U-Boot] [PATCH] arm: socfpga: config: Add USB support example

[Marek Vasut]

Add example configuration stub for the DWC2 USB controller.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Chin Liang See <clsee@altera.com>
Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: Vince Bridgers <vbridger@altera.com>
Cc: Pavel Machek <pavel@denx.de>
---
 include/configs/socfpga_common.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
index 9de3aa7..1df886b 100644
--- a/include/configs/socfpga_common.h
+++ b/include/configs/socfpga_common.h
@@ -176,6 +176,21 @@
 #define CONFIG_BAUDRATE			115200
 
 /*
+ * USB
+ */
+#ifdef CONFIG_CMD_USB
+#define CONFIG_USB_DWC2
+#define CONFIG_USB_STORAGE
+/*
+ * NOTE: User must define either of the following to select which
+ *       of the two USB controllers available on SoCFPGA to use.
+ *       The DWC2 driver doesn't support multiple USB controllers.
+ * #define CONFIG_USB_DWC2_REG_ADDR	SOCFPGA_USB0_ADDRESS
+ * #define CONFIG_USB_DWC2_REG_ADDR	SOCFPGA_USB1_ADDRESS
+ */
+#endif
+
+/*
  * U-Boot environment
  */
 #define CONFIG_SYS_CONSOLE_IS_IN_ENV
-- 
2.0.0

[U-Boot] [PATCH] arm: socfpga: config: Add USB support example

[Pavel Machek]

On Fri 2014-10-24 23:34:25, Marek Vasut wrote:
> Add example configuration stub for the DWC2 USB controller.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Vince Bridgers <vbridger@altera.com>
> Cc: Pavel Machek <pavel@denx.de>
> ---
>  include/configs/socfpga_common.h | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
> index 9de3aa7..1df886b 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -176,6 +176,21 @@
>  #define CONFIG_BAUDRATE			115200
>  
>  /*
> + * USB
> + */
> +#ifdef CONFIG_CMD_USB
> +#define CONFIG_USB_DWC2
> +#define CONFIG_USB_STORAGE
> +/*
> + * NOTE: User must define either of the following to select which
> + *       of the two USB controllers available on SoCFPGA to use.
> + *       The DWC2 driver doesn't support multiple USB controllers.
> + * #define CONFIG_USB_DWC2_REG_ADDR	SOCFPGA_USB0_ADDRESS
> + * #define CONFIG_USB_DWC2_REG_ADDR	SOCFPGA_USB1_ADDRESS
> + */
> +#endif
> +
> +/*

Actually, I believe you should uncomment whatever configuration works
for you. That way, users can see what you are actually using/testing.

With that:

Acked-by: Pavel Machek <pavel@denx.de>
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[U-Boot] [PATCH] arm: socfpga: config: Add USB support example

[Marek Vasut]

On Saturday, October 25, 2014 at 01:16:00 PM, Pavel Machek wrote:
> On Fri 2014-10-24 23:34:25, Marek Vasut wrote:
> > Add example configuration stub for the DWC2 USB controller.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Chin Liang See <clsee@altera.com>
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Cc: Vince Bridgers <vbridger@altera.com>
> > Cc: Pavel Machek <pavel@denx.de>
> > ---
> > 
> >  include/configs/socfpga_common.h | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/include/configs/socfpga_common.h
> > b/include/configs/socfpga_common.h index 9de3aa7..1df886b 100644
> > --- a/include/configs/socfpga_common.h
> > +++ b/include/configs/socfpga_common.h
> > @@ -176,6 +176,21 @@
> > 
> >  #define CONFIG_BAUDRATE			115200
> >  
> >  /*
> > 
> > + * USB
> > + */
> > +#ifdef CONFIG_CMD_USB
> > +#define CONFIG_USB_DWC2
> > +#define CONFIG_USB_STORAGE
> > +/*
> > + * NOTE: User must define either of the following to select which
> > + *       of the two USB controllers available on SoCFPGA to use.
> > + *       The DWC2 driver doesn't support multiple USB controllers.
> > + * #define CONFIG_USB_DWC2_REG_ADDR	SOCFPGA_USB0_ADDRESS
> > + * #define CONFIG_USB_DWC2_REG_ADDR	SOCFPGA_USB1_ADDRESS
> > + */
> > +#endif
> > +
> > +/*
> 
> Actually, I believe you should uncomment whatever configuration works
> for you. That way, users can see what you are actually using/testing.

This is common config code, the user is supposed to define his own setup in
board config code (ie. socfpga_cyclone5.h) . A subsequent patch doing just
that would be fine.

> With that:
> 
> Acked-by: Pavel Machek <pavel@denx.de>
> 									Pavel

Best regards,
Marek Vasut

[U-Boot] [PATCH] arm: socfpga: config: Add USB support example

[Marek Vasut]

On Friday, October 24, 2014 at 11:34:25 PM, Marek Vasut wrote:
> Add example configuration stub for the DWC2 USB controller.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Chin Liang See <clsee@altera.com>
> Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Vince Bridgers <vbridger@altera.com>
> Cc: Pavel Machek <pavel@denx.de>

Applied, thanks!

Best regards,
Marek Vasut