[U-Boot] [PATCH] cti_flash.c: use __weak for flash_(read|write){8, 16, 32, 64}

Tom Rini
2014-10-27T00:35:27Z

On Fri, Oct 24, 2014 at 04:18:30PM -0400, Tom Rini wrote:

> From: Jeroen Hofstee <jeroen@myspectrum.nl>
>
> For various reasons (flash access design, errata work-around) some
> platforms need to implement their own flash_read/write functions, so
> mark them as __weak. A follow-up cleanup here would be to remove
> CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS if this is always known at
> compile-time, as it appears to be.
>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Signed-off-by: Tom Rini <trini@ti.com>

On IRC, Jeroen pointed out that this way does change behavior and
potentially performance since in the normal case these functions no
longer get inlined. So I'm withdrawing this patch.

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141026/a809626a/attachment.pgp>