* [U-Boot] [PATCH] gic: fixed compilation error in GICv2 wait for interrupt macro
@ 2014-10-27 12:07 Yehuda Yitschak
2014-10-27 13:04 ` Albert ARIBAUD
2014-10-28 6:58 ` Albert ARIBAUD
0 siblings, 2 replies; 5+ messages in thread
From: Yehuda Yitschak @ 2014-10-27 12:07 UTC (permalink / raw)
To: u-boot
a hexadicemal value was missing the "0x" prefix which caused
assembler error
Signed-off-by: Yehuda Yitschak <yehuday@marvell.com>
---
arch/arm/include/asm/macro.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/macro.h b/arch/arm/include/asm/macro.h
index 541b443..1c8c425 100644
--- a/arch/arm/include/asm/macro.h
+++ b/arch/arm/include/asm/macro.h
@@ -193,7 +193,7 @@ lr .req x30
0 : wfi
ldr \wreg2, [\xreg1, GICC_AIAR]
str \wreg2, [\xreg1, GICC_AEOIR]
- and \wreg2, \wreg2, #3ff
+ and \wreg2, \wreg2, #0x3ff
cbnz \wreg2, 0b
.endm
#endif
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] gic: fixed compilation error in GICv2 wait for interrupt macro
2014-10-27 12:07 [U-Boot] [PATCH] gic: fixed compilation error in GICv2 wait for interrupt macro Yehuda Yitschak
@ 2014-10-27 13:04 ` Albert ARIBAUD
2014-10-27 14:29 ` Yehuda Yitschak
2014-10-28 6:58 ` Albert ARIBAUD
1 sibling, 1 reply; 5+ messages in thread
From: Albert ARIBAUD @ 2014-10-27 13:04 UTC (permalink / raw)
To: u-boot
Hello Yehuda,
On Mon, 27 Oct 2014 14:07:16 +0200, Yehuda Yitschak
<yehuday@marvell.com> wrote:
> a hexadicemal value was missing the "0x" prefix which caused
> assembler error
>
> Signed-off-by: Yehuda Yitschak <yehuday@marvell.com>
> ---
> arch/arm/include/asm/macro.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/macro.h b/arch/arm/include/asm/macro.h
> index 541b443..1c8c425 100644
> --- a/arch/arm/include/asm/macro.h
> +++ b/arch/arm/include/asm/macro.h
> @@ -193,7 +193,7 @@ lr .req x30
> 0 : wfi
> ldr \wreg2, [\xreg1, GICC_AIAR]
> str \wreg2, [\xreg1, GICC_AEOIR]
> - and \wreg2, \wreg2, #3ff
> + and \wreg2, \wreg2, #0x3ff
> cbnz \wreg2, 0b
> .endm
> #endif
> --
> 1.8.1.2
Which board(s) does this error show up in?
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] gic: fixed compilation error in GICv2 wait for interrupt macro
2014-10-27 13:04 ` Albert ARIBAUD
@ 2014-10-27 14:29 ` Yehuda Yitschak
2014-10-27 17:12 ` Albert ARIBAUD
0 siblings, 1 reply; 5+ messages in thread
From: Yehuda Yitschak @ 2014-10-27 14:29 UTC (permalink / raw)
To: u-boot
Hello Albert
> -----Original Message-----
> From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
> Sent: Monday, October 27, 2014 15:05
> To: Yehuda Yitschak
> Cc: u-boot at lists.denx.de; arnab.basu at freescale.com;
> fenghua at phytium.com.cn; yorksun at freescale.com;
> scottwood at freescale.com
> Subject: Re: [PATCH] gic: fixed compilation error in GICv2 wait for interrupt
> macro
>
> Hello Yehuda,
>
> On Mon, 27 Oct 2014 14:07:16 +0200, Yehuda Yitschak
> <yehuday@marvell.com> wrote:
> > a hexadicemal value was missing the "0x" prefix which caused
> > assembler error
> >
> > Signed-off-by: Yehuda Yitschak <yehuday@marvell.com>
> > ---
> > arch/arm/include/asm/macro.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/include/asm/macro.h
> > b/arch/arm/include/asm/macro.h index 541b443..1c8c425 100644
> > --- a/arch/arm/include/asm/macro.h
> > +++ b/arch/arm/include/asm/macro.h
> > @@ -193,7 +193,7 @@ lr .req x30
> > 0 : wfi
> > ldr \wreg2, [\xreg1, GICC_AIAR]
> > str \wreg2, [\xreg1, GICC_AEOIR]
> > - and \wreg2, \wreg2, #3ff
> > + and \wreg2, \wreg2, #0x3ff
> > cbnz \wreg2, 0b
> > .endm
> > #endif
> > --
> > 1.8.1.2
>
> Which board(s) does this error show up in?
There is no board in u-boot 2014.01 that use GICv2. I guess this is why it went under radar
I use mainline u-boot for one of my platforms so I noticed the bug once I rebased to 2014.10
Yehuda
>
> Amicalement,
> --
> Albert.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] gic: fixed compilation error in GICv2 wait for interrupt macro
2014-10-27 14:29 ` Yehuda Yitschak
@ 2014-10-27 17:12 ` Albert ARIBAUD
0 siblings, 0 replies; 5+ messages in thread
From: Albert ARIBAUD @ 2014-10-27 17:12 UTC (permalink / raw)
To: u-boot
Hello Yehuda,
On Mon, 27 Oct 2014 14:29:09 +0000, Yehuda Yitschak
<yehuday@marvell.com> wrote:
> Hello Albert
> > Which board(s) does this error show up in?
>
> There is no board in u-boot 2014.01 that use GICv2. I guess this is why it went under radar
> I use mainline u-boot for one of my platforms so I noticed the bug once I rebased to 2014.10
Thanks for the explanation.
> Yehuda
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH] gic: fixed compilation error in GICv2 wait for interrupt macro
2014-10-27 12:07 [U-Boot] [PATCH] gic: fixed compilation error in GICv2 wait for interrupt macro Yehuda Yitschak
2014-10-27 13:04 ` Albert ARIBAUD
@ 2014-10-28 6:58 ` Albert ARIBAUD
1 sibling, 0 replies; 5+ messages in thread
From: Albert ARIBAUD @ 2014-10-28 6:58 UTC (permalink / raw)
To: u-boot
Hello Yehuda,
On Mon, 27 Oct 2014 14:07:16 +0200, Yehuda Yitschak
<yehuday@marvell.com> wrote:
> a hexadicemal value was missing the "0x" prefix which caused
> assembler error
>
> Signed-off-by: Yehuda Yitschak <yehuday@marvell.com>
> ---
> arch/arm/include/asm/macro.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/macro.h b/arch/arm/include/asm/macro.h
> index 541b443..1c8c425 100644
> --- a/arch/arm/include/asm/macro.h
> +++ b/arch/arm/include/asm/macro.h
> @@ -193,7 +193,7 @@ lr .req x30
> 0 : wfi
> ldr \wreg2, [\xreg1, GICC_AIAR]
> str \wreg2, [\xreg1, GICC_AEOIR]
> - and \wreg2, \wreg2, #3ff
> + and \wreg2, \wreg2, #0x3ff
> cbnz \wreg2, 0b
> .endm
> #endif
> --
> 1.8.1.2
Applied to u-boot-arm/master (as a preventive bug fix), thanks!
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-28 6:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-27 12:07 [U-Boot] [PATCH] gic: fixed compilation error in GICv2 wait for interrupt macro Yehuda Yitschak
2014-10-27 13:04 ` Albert ARIBAUD
2014-10-27 14:29 ` Yehuda Yitschak
2014-10-27 17:12 ` Albert ARIBAUD
2014-10-28 6:58 ` Albert ARIBAUD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox