From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Revert "common, env: Fix support for environment in i2c eeprom"
Date: Mon, 27 Oct 2014 18:19:59 -0400 [thread overview]
Message-ID: <20141027221959.GI25506@bill-the-cat> (raw)
In-Reply-To: <1413278193-28886-1-git-send-email-valentin.longchamp@keymile.com>
On Tue, Oct 14, 2014 at 11:16:33AM +0200, Valentin Longchamp wrote:
> Since i2c_init_all always sets the bus back to CONFIG_SYS_SPD_BUS_NUM
> for compatibility reasons, it means that any eeprom not located on this
> CONFIG_SYS_SPD_BUS_NUM is not accessible with the eeprom commands, even
> if you change the bus number with an i2c dev command before.
>
> Furthermore i2c_init_all should disappear and is currently only called
> from the early board initialisation sequences, it is not suited for
> other usage.
>
> This reverts commit 01a0c64762e902971b34587a8a61b59e9ea51374.
>
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> Acked-by: Matthias Fuchs <matthias.fuchs@esd.eu>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141027/fdbe1228/attachment.pgp>
prev parent reply other threads:[~2014-10-27 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 9:16 [U-Boot] [PATCH] Revert "common, env: Fix support for environment in i2c eeprom" Valentin Longchamp
2014-10-14 12:32 ` Matthias Fuchs
2014-10-14 13:01 ` Holger Brunck
2014-10-14 14:20 ` Matthias Fuchs
2014-10-14 14:21 ` Valentin Longchamp
2014-10-23 14:15 ` Matthias Fuchs
2014-10-23 15:11 ` Tom Rini
2014-10-23 15:29 ` Matthias Fuchs
2014-10-27 22:19 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027221959.GI25506@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox