From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 28 Oct 2014 10:33:48 +0100 Subject: [U-Boot] [PATCH] Disable FLASH_AMLV256U support for TOP860 target In-Reply-To: References: <1402929691-3972-1-git-send-email-vvv444@gmail.com> Message-ID: <20141028093348.43664382FEC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Vasili, In message you wrote: > > > TOP860 configuration assumes at most 128 flash sectors. Thus, the > > AMLV256U flash can't be supported. The existing code could result in > > memory corruption when writing to the flash_info->start[] array. > > > > Signed-off-by: Vasili Galka > > Cc: Wolfgang Denk > > --- > > board/emk/common/flash.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/board/emk/common/flash.c b/board/emk/common/flash.c > > index ae5777c..4119b3b 100644 > > --- a/board/emk/common/flash.c > > +++ b/board/emk/common/flash.c > > @@ -324,6 +324,7 @@ ulong flash_get_size (FPWV *addr, flash_info_t *info) > > } > > break; > > } > > +#ifndef CONFIG_TOP860 > > if ((FPW)addr[FLASH_ID3] == (FPW)AMD_ID_LV256U_2 && > > (FPW)addr[FLASH_ID4] == (FPW)AMD_ID_LV256U_3) > > { > > @@ -337,7 +338,8 @@ ulong flash_get_size (FPWV *addr, flash_info_t *info) > > } > > break; > > } > > - > > +#endif > > + > > /* fall thru to here ! */ > > default: > > printf ("unknown AMD device=%x %x %x", > > -- > > 1.7.9 > > > > > Any review? > This was inspired by a a compiler warning. I'm still getting this warning > on the latest master. Sorry, I missed that one. Would it not be more appropriate to adjust the CONFIG_SYS_MAX_FLASH_SECT setting in "include/configs/TOP860.h"? Or are you 100% sure that there were never be any AMLV256U flash chips fit on a TOP860 board? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "I've finally learned what `upward compatible' means. It means we get to keep all our old mistakes." - Dennie van Tassel