public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Disable FLASH_AMLV256U support for TOP860 target
Date: Tue, 28 Oct 2014 11:40:40 +0100	[thread overview]
Message-ID: <20141028104040.3BAB8382FFB@gemini.denx.de> (raw)
In-Reply-To: <544F7157.9040701@emk-elektronik.de>

Dear Reinhard,

In message <544F7157.9040701@emk-elektronik.de> you wrote:
>
> > - am79c874.c is completely bogus anyway
> How so?

Because it contains just a single code line:

	#include <common.h>

That does not generate any executable code...

> > - flash.c should have been replaced by the CFI driver years ago
> I think there was/is an issue with the fact that top5200 uses GPIO for 
> the uppermost (A16+) address lines AND that FLASH is connected 8 Bit wide.
> Maybe CFI code does support such by now, at that time it did not.
> > - vpd.c is causing efforts when I2C / EEPROM code gets changed
> ideally, the API should not change that often ;)
> >
> > What do you think?
> Since its quite unlikely I will make any changes to those boards in the 
> future, they can be removed.

Excellent.  I'll prepare a patch, then.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How many seconds are there in a year? If I tell you there are 3.155 x
10^7, you won't even try to remember it. On the other hand, who could
forget that, to within half a percent, pi seconds is a nanocentury.
                                                - Tom Duff, Bell Labs

      reply	other threads:[~2014-10-28 10:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16 14:41 [U-Boot] [PATCH] Disable FLASH_AMLV256U support for TOP860 target Vasili Galka
2014-08-12 15:17 ` Vasili Galka
2014-10-28  9:33   ` Wolfgang Denk
     [not found]     ` <CA+gZxsPKtwYAhHm88fBtGW17cxT7ncEz9OBxwpqiJ55WR-kfcg@mail.gmail.com>
2014-10-28  9:48       ` Wolfgang Denk
2014-10-28 10:07         ` Reinhard Meyer
2014-10-28 10:23           ` Wolfgang Denk
2014-10-28 10:35             ` Reinhard Meyer
2014-10-28 10:40               ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141028104040.3BAB8382FFB@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox